Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swush-dex-aggregator.md #2502

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Update swush-dex-aggregator.md #2502

merged 2 commits into from
Feb 6, 2025

Conversation

muddlebee
Copy link
Contributor

@muddlebee muddlebee commented Feb 5, 2025

updating application as per discussion at #2440 (comment)

  • Removed the section of simulation in Milestone 1 and pushed to Milestone 2 with Chopsticks as the earlier approach was very different and now all the features can be tested with Chopsticks itself.
  • Added APIs like asset info/metadata, asset balance and asset pair swap to cover all scenarios.

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Feb 5, 2025
@semuelle semuelle removed the admin-review This application requires a review from an admin. label Feb 5, 2025
@keeganquigley
Copy link
Contributor

Thanks @muddlebee just to be clear, you would still include comprehensive unit tests for all functionality and performance, correct? Does chopsticks allow for simulating testing transaction reliability across multiple (test) chains? Since this language is being taken out completely, I just want to make that sufficient tests will still be provided.

@muddlebee
Copy link
Contributor Author

muddlebee commented Feb 5, 2025

@keeganquigley GM

you would still include comprehensive unit tests for all functionality and performance, correct?

yes

Does chopsticks allow for simulating testing transaction reliability across multiple (test) chains?

yes, we can use chopsticks for all kinds of transactions including XCMs too. Here's one sample example I came across earlier involving chopsticks and testing on multiple networks.

Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ok thx for comfirming. LGTM

@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. amendment This PR proposes changes to an existing application. labels Feb 5, 2025
@takahser takahser merged commit 9cb35f5 into w3f:master Feb 6, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants