Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify embedded Hebrew xml:lang; update expectations (#7). #8

Merged
merged 3 commits into from
Aug 8, 2021

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Aug 3, 2021

Closes #7.

Copy link

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the following two issues related?

  • addition of xml:lang
  • update to expectations

@skynavga
Copy link
Collaborator Author

skynavga commented Aug 3, 2021

@palemieux

svg rendering artifact difference only refers to changes in ttpe that generate different svg outputs while still retaining the same visual result; these are housekeeping updates that keep the expectations synchronized with ttpe

@skynavga
Copy link
Collaborator Author

skynavga commented Aug 3, 2021

Removed erroneously updated expectation noted above in #8 (comment).

@skynavga
Copy link
Collaborator Author

skynavga commented Aug 3, 2021

@palemieux any further comment or change requested?

@skynavga skynavga requested a review from palemieux August 4, 2021 01:47
@palemieux
Copy link

@skynavga Can you provide a PNG of the expected results, to remove the SVG rendered from the chain?

@skynavga
Copy link
Collaborator Author

skynavga commented Aug 5, 2021

@palemieux re: #8 (comment), in theory yes, but in practice no; I would be happy to explain my reasons in a ttwg call;

@skynavga
Copy link
Collaborator Author

skynavga commented Aug 5, 2021

@palemieux to elaborate a bit:

  • there are at present 190 *.expected.zip files in the w3c/ttml1-tests and w3c/ttml1-tests repositories, all of which would have to be converted, or 190 additional *.png.expected.zip files added, a substantial project that would require sponsorship;
  • the current expectation files were provided by Skynav to the group when these two repositories were populated for exemplar purposes only and for use as evidence of some (non-normative) rendering for implementation reports;
  • the current README.md files of both this repository w3c/ttml1-tests and w3c/ttml1-tests include the following text:

For tests having primarily visual presentation semantics, each presentation test is associated with a like named ZIP archive with the suffix .expected.zip, which contains the output of a particular reference implementation (TTPE). Each such reference archive contains a manifest file and one or more image frames represented in some image format. In the present form of the reference archives, the image format is image/svg+xml. These image frames should not be construed as normative, but merely serve as a possible reference image for performing (human visual) comparisons of expected output.

  • the use of PNG files as an alternative to SVG effectively makes some SVG renderer implementation a dependency, at least with respect to using TTPE;
  • at present the SVG renderer used by TTPE is Apache Batik, which is quite dated and almost entirely unmaintained, meaning that I don't trust it as a normative renderer; using an alternative SVG renderer would require revision of TTPE, a substantial project that would require sponsorship, and the result would still be to have such alternative renderer as a dependency;
  • the original (and current) requirement for use of the expectation files w.r.t. TTPE is to enable regression testing that is independent of SVG rendering, i.e., independent of actual pixel output; therefore, changing to PNG renderings would abrogate this requirement;
  • finally, if you are asking me to provide an extra-exemplary rendering of a particular SVG output from TTPE, for discussion purposes only (i..e., not to go into the repository), then I could arrange for that; I would simple use Chrome to render the SVG and then take a screen shot of the results on my MacOS laptop; then again, you (or anyone) can already do this without my help;

@skynavga skynavga dismissed palemieux’s stale review August 8, 2021 13:26

Comments addressed.

@skynavga skynavga merged commit 3241bc6 into main Aug 8, 2021
@skynavga skynavga deleted the issue-0007-ttml1-prstn-direction branch August 8, 2021 14:53
@nigelmegitt nigelmegitt restored the issue-0007-ttml1-prstn-direction branch August 23, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update direction test and expectations.
3 participants