-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify embedded Hebrew xml:lang; update expectations (#7). #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are the following two issues related?
- addition of
xml:lang
- update to expectations
svg rendering artifact difference only refers to changes in ttpe that generate different svg outputs while still retaining the same visual result; these are housekeeping updates that keep the expectations synchronized with ttpe |
Removed erroneously updated expectation noted above in #8 (comment). |
@palemieux any further comment or change requested? |
@skynavga Can you provide a PNG of the expected results, to remove the SVG rendered from the chain? |
@palemieux re: #8 (comment), in theory yes, but in practice no; I would be happy to explain my reasons in a ttwg call; |
@palemieux to elaborate a bit:
|
Closes #7.