Skip to content

fix: add @vue/compiler-sfc as dependency for yarn 2+ #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2025
Merged

fix: add @vue/compiler-sfc as dependency for yarn 2+ #73

merged 3 commits into from
Apr 27, 2025

Conversation

AndreyYolkin
Copy link
Contributor

Also change folder structure to have pre-post install hooks

Closes #55

@AndreyYolkin
fix: add @vue/compiler-sfc as dependency for yarn 2+
c010d83 
Also change folder structure to have pre-post install hooks
@AndreyYolkin AndreyYolkin self-assigned this Apr 25, 2025
@AndreyYolkin AndreyYolkin requested review from userquin, johnleider and KaelWD and removed request for KaelWD April 25, 2025 21:48
@AndreyYolkin AndreyYolkin added the bug Something isn't working label Apr 25, 2025
@AndreyYolkin AndreyYolkin added this to the 2.5.0 milestone Apr 25, 2025
@userquin
Copy link
Member

userquin commented Apr 25, 2025 •
edited
Loading

cannot use package-manager-detector to detect yarn? Check latest changes, 1.0.0 is outdated, latest 1.2.0 with some more utilities.

@AndreyYolkin
refactor: call pre- and post- hooks asynchronously
41dfd45 
Update `package-manager-detector` to v1.2.0 and add `tinyexec` as a dependency. Refactor `execSync` calls to use `tinyexec`
@AndreyYolkin
Copy link
Contributor Author

cannot use package-manager-detector to detect yarn? Check latest changes, 1.0.0 is outdated, latest 1.2.0 with some more utilities.

We can't. package-manager-detector can make a guess because before installation it only relies on userAgent. Moreover, these patches are for specific versions and detect() couldn't provide that sometimes

That's what detect() return after installation with pnpm (I need to know its version is 10+)
image

@AndreyYolkin AndreyYolkin merged commit 64dc19a into master Apr 27, 2025
1 check passed
@johnleider johnleider deleted the ae-fix-yarn-pnp branch April 30, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider johnleider approved these changes

@userquin userquin Awaiting requested review from userquin

Assignees

@AndreyYolkin AndreyYolkin

Labels
bug Something isn't working yarn
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

yarn: create template missing dependency
3 participants
@AndreyYolkin @userquin @johnleider