Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Hide Menu on Launch" Setting #121

Closed

Conversation

NGenesis
Copy link

Adds a "Hide Menu on Launch" setting to support automatically hiding the ClientSim menu when initially entering play mode for rapid development iteration.

…f the ClientSim menu when initially entering playmode.
Copy link
Collaborator

@momo-the-monster momo-the-monster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works for me. Running through internal QA process now.

Copy link
Collaborator

@momo-the-monster momo-the-monster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA found an issue - when this code is implemented, the ClientSim menu no longer appears when you press escape. This menu has helpful functions and, as a creator, I wouldn't expect the 'hide menu on launch' toggle to disable it completely.

I've got another approach working internally - closing the ClientSim menu when you move your player, similar to how the QuickMenu closes in the VRChat Client when you move. I'm putting that through QA now and un-approving this change. Let me know what you think!

@momo-the-monster
Copy link
Collaborator

The update inspired by this PR has just passed QA, and will go into the next SDK release:

  • Adds a new ClientSim setting - "Hide Menu on Launch", which automatically closes the ClientSim pause menu when entering Play Mode, after you've accepted the warning about differences between ClientSim and the VRChat Client.
  • Automatically closes the ClientSim pause menu when you move your player, similar to how the Quick Menu works in the Client.

I will close out this PR unmerged, thanks for your contribution!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants