🌱 Handle zones that are being deleted under WCP_Workload_Domain_Isolation #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyiyi11
force-pushed
the
topic/zyiyi/handle-deleted-zone
branch
from
7684d5f to
e303080
Compare
github-actions
bot
added
size/M
zyiyi11
force-pushed
the
topic/zyiyi/handle-deleted-zone
branch
3 times, most recently
from
6e68ca3 to
0d4f9e8
Compare
bryanv
reviewed
Aug 19, 2024
zyiyi11
force-pushed
the
topic/zyiyi/handle-deleted-zone
branch
2 times, most recently
from
1a24190 to
371f863
Compare
bryanv
reviewed
Aug 20, 2024
bryanv
reviewed
Aug 20, 2024
zyiyi11
force-pushed
the
topic/zyiyi/handle-deleted-zone
branch
from
371f863 to
2c91617
Compare
github-actions
bot
added
size/L
Minimum allowed line rate is |
bryanv
approved these changes
Aug 22, 2024
zyiyi11
added a commit
to zyiyi11/vm-operator
that referenced
this pull request
Aug 22, 2024
This patch handles Zones that are being deleted. We don't want to allow new VMs to be created in zones that are being deleted. - If VM deployment specifies a zone that is being deleted by SSO user, validation webhook will reject the creation. - If VM deployment specifies a zone that is being deleted by admin, validation webhook will allow the creation. - If VM deployment specifies a valid zone at create time, zone got deletionTimestamp later, still place it in the zone. - For placement, filter out the to be deleted zones so we don't have it as a candidate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch handles Zones that are being deleted. We don't want to allow new VMs to be created in zones that are being deleted.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # N/A
Are there any special notes for your reviewer:
Testing done:
zone-2andzone-3.zone-2and 1 landed onzone-3zone-2deletion initiatedzone-2has deletionTimestamp but not deleted yet with workloads still on.topology.kubernetes.io/zone: zone-2is rejected.zone-3as expected.Please add a release note if necessary: