✨ Perennial properties #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/set-vm-namespace-name-in-extraconfig
branch
5 times, most recently
from
eb56aba to
083ea70
Compare
github-actions
bot
added
size/XL
akutz
force-pushed
the
feature/set-vm-namespace-name-in-extraconfig
branch
from
083ea70 to
60f4b3a
Compare
github-actions
bot
added
size/L
akutz
force-pushed
the
feature/set-vm-namespace-name-in-extraconfig
branch
2 times, most recently
from
0e781a6 to
0843493
Compare
github-actions
bot
added
size/XL
akutz
force-pushed
the
feature/set-vm-namespace-name-in-extraconfig
branch
3 times, most recently
from
58204bf to
52dcfbe
Compare
bryanv
reviewed
Aug 8, 2024
akutz
force-pushed
the
feature/set-vm-namespace-name-in-extraconfig
branch
4 times, most recently
from
0735f1f to
f06525d
Compare
1. The VM object's namespace and name are stored in ExtraConfig as the keys vmservice.namespace and vmservice.name. 2. The VM's vSphere property config.managedBy is always set to reflect the VM is managed by VM Service if it is not set to this value. 3. There is now support for always ensuring certain properties are set during each reconcile, regardless of the VM's power state or whether or not the VM is paused by the admin. For example, the aforementioned namespace/name ExtraConfig keys are included, as well as the VM's config.managedBy property.
akutz
force-pushed
the
feature/set-vm-namespace-name-in-extraconfig
branch
from
f06525d to
09ac39a
Compare
Minimum allowed line rate is |
bryanv
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch does three things:
The VM object's namespace and name are stored in ExtraConfig as the keys
vmservice.namespaceandvmservice.name.The VM's vSphere property
config.managedByis always set to reflect the VM is managed by VM Service if it is not set to this value.There is now support for always ensuring certain properties are set during each reconcile, regardless of the VM's power state or whether or not the VM is paused by the admin. For example, the aforementioned namespace/name ExtraConfig keys are included, as well as the VM's
config.managedByproperty.Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: