Remove metrics port from backup-driver deployment #601

deepakkinni · 2025-01-14T21:13:48Z

What this PR does / why we need it:
Removes metrics port from backup-driver deployment spec.

Which issue(s) this PR fixes:
Fixes # PR 3471190

Special notes for your reviewer:
None

Testing:

❯ make test
running docker: shell
docker run \
                --platform linux/amd64 \
                -e GOFLAGS \
                -i -t \
                --rm \
                -u $(id -u):$(id -g) \
                -v $(pwd)/.libs/vmware-vix-disklib-distrib:/usr/local/vmware-vix-disklib-distrib:delegated \
                -v $(pwd)/.go/pkg:/go/pkg:delegated \
                -v $(pwd)/.go/src:/go/src:delegated \
                -v $(pwd)/.go/std:/go/std:delegated \
                -v $(pwd):/go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere:delegated \
                -v "$(pwd)/_output/bin:/output:delegated" \
                -v $(pwd)/.go/std/linux/amd64:/usr/local/go/pkg/linux/amd64_static:delegated \
                -v "$(pwd)/.go/go-build:/.cache/go-build:delegated" \
                -e CGO_ENABLED=1 \
                -e GOPATH=/go \
                -w /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere \
                golang:1.18 \
                /bin/sh -c '     VDDK_LIBS=github.com/vmware-tanzu/velero-plugin-for-vsphere/.libs/vmware-vix-disklib-distrib/lib64      TARGETS=./pkg/...      TIMEOUT=300s      VERBOSE=      DISABLE_CACHE=      RUN_SINGLE_CASE=      hack/test.sh'
Running tests: ./pkg/...
go test ./pkg/... -timeout=300s
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/apis/backupdriver/v1alpha1        [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/apis/datamover/v1alpha1   [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backupdriver      [no test files]
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backuprepository  (cached)
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/builder   [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/buildinfo [no test files]
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd       0.085s
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/backupdriver  [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/backupdriver/cli/install      [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/backupdriver/cli/server       [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/datamgr       [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/datamgr/cli/install   [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/cmd/datamgr/cli/server    [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/common/config     [no test files]
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/common/vsphere    (cached)
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/constants [no test files]
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/controller        (cached)
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/dataMover [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned     [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/fake        [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/scheme      [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/typed/backupdriver/v1alpha1 [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/typed/backupdriver/v1alpha1/fake    [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/typed/datamover/v1alpha1    [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/clientset/versioned/typed/datamover/v1alpha1/fake       [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/crds    [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions      [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/backupdriver [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/backupdriver/v1alpha1        [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/datamover    [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/datamover/v1alpha1   [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/informers/externalversions/internalinterfaces   [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/listers/backupdriver/v1alpha1   [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/generated/listers/datamover/v1alpha1      [no test files]
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/install   [no test files]
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/ivd       (cached)
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/paravirt  (cached)
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/plugin    [no test files]
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/plugin/util       (cached)
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/snapshotUtils     (cached)
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/snapshotmgr       (cached)
?       github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/test      [no test files]
ok      github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/utils     (cached)
Success!


❯ REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni VERSION=rem_metric_port_v1 make container
making: datamgr
/Library/Developer/CommandLineTools/usr/bin/make build BIN=data-manager-for-plugin VERSION=rem_metric_port_v1
skip copying astrolabe as it is not available at /Users/dkinni/go/src/github.com/vmware-tanzu/astrolabe
building: _output/bin/linux/amd64/data-manager-for-plugin
/Library/Developer/CommandLineTools/usr/bin/make shell CMD="-c '\
                GOOS=linux \
                GOARCH=amd64 \
                REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni \
                VERSION=rem_metric_port_v1 \
                PKG=github.com/vmware-tanzu/velero-plugin-for-vsphere \
                BIN=data-manager-for-plugin \
                GIT_SHA=0d8dd16add9baf258847b8853e982c1c9c234994 \
                GIT_DIRTY=\"\" \
                OUTPUT_DIR=/output/linux/amd64 \
                GO111MODULE=on \
                GOFLAGS=-mod=readonly \
                ./hack/build.sh'"
running docker: shell
docker run \
                --platform linux/amd64 \
                -e GOFLAGS \
                -i -t \
                --rm \
                -u $(id -u):$(id -g) \
                -v $(pwd)/.libs/vmware-vix-disklib-distrib:/usr/local/vmware-vix-disklib-distrib:delegated \
                -v $(pwd)/.go/pkg:/go/pkg:delegated \
                -v $(pwd)/.go/src:/go/src:delegated \
                -v $(pwd)/.go/std:/go/std:delegated \
                -v $(pwd):/go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere:delegated \
                -v "$(pwd)/_output/bin:/output:delegated" \
                -v $(pwd)/.go/std/linux/amd64:/usr/local/go/pkg/linux/amd64_static:delegated \
                -v "$(pwd)/.go/go-build:/.cache/go-build:delegated" \
                -e CGO_ENABLED=1 \
                -e GOPATH=/go \
                -w /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere \
                golang:1.18 \
                /bin/sh -c '    GOOS=linux      GOARCH=amd64    REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni         VERSION=rem_metric_port_v1      PKG=github.com/vmware-tanzu/velero-plugin-for-vsphere   BIN=data-manager-for-plugin     GIT_SHA=0d8dd16add9baf258847b8853e982c1c9c234994       GIT_DIRTY=""     OUTPUT_DIR=/output/linux/amd64  GO111MODULE=on  GOFLAGS=-mod=readonly   ./hack/build.sh'
making: backup-driver
/Library/Developer/CommandLineTools/usr/bin/make build BIN=backup-driver VERSION=rem_metric_port_v1
skip copying astrolabe as it is not available at /Users/dkinni/go/src/github.com/vmware-tanzu/astrolabe
building: _output/bin/linux/amd64/backup-driver
/Library/Developer/CommandLineTools/usr/bin/make shell CMD="-c '\
                GOOS=linux \
                GOARCH=amd64 \
                REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni \
                VERSION=rem_metric_port_v1 \
                PKG=github.com/vmware-tanzu/velero-plugin-for-vsphere \
                BIN=backup-driver \
                GIT_SHA=0d8dd16add9baf258847b8853e982c1c9c234994 \
                GIT_DIRTY=\"\" \
                OUTPUT_DIR=/output/linux/amd64 \
                GO111MODULE=on \
                GOFLAGS=-mod=readonly \
                ./hack/build.sh'"
running docker: shell
docker run \
                --platform linux/amd64 \
                -e GOFLAGS \
                -i -t \
                --rm \
                -u $(id -u):$(id -g) \
                -v $(pwd)/.libs/vmware-vix-disklib-distrib:/usr/local/vmware-vix-disklib-distrib:delegated \
                -v $(pwd)/.go/pkg:/go/pkg:delegated \
                -v $(pwd)/.go/src:/go/src:delegated \
                -v $(pwd)/.go/std:/go/std:delegated \
                -v $(pwd):/go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere:delegated \
                -v "$(pwd)/_output/bin:/output:delegated" \
                -v $(pwd)/.go/std/linux/amd64:/usr/local/go/pkg/linux/amd64_static:delegated \
                -v "$(pwd)/.go/go-build:/.cache/go-build:delegated" \
                -e CGO_ENABLED=1 \
                -e GOPATH=/go \
                -w /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere \
                golang:1.18 \
                /bin/sh -c '    GOOS=linux      GOARCH=amd64    REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni         VERSION=rem_metric_port_v1      PKG=github.com/vmware-tanzu/velero-plugin-for-vsphere   BIN=backup-driver       GIT_SHA=0d8dd16add9baf258847b8853e982c1c9c234994        GIT_DIRTY=""    OUTPUT_DIR=/output/linux/amd64  GO111MODULE=on  GOFLAGS=-mod=readonly   ./hack/build.sh'
making: plugin
/Library/Developer/CommandLineTools/usr/bin/make build BIN=velero-plugin-for-vsphere VERSION=rem_metric_port_v1
skip copying astrolabe as it is not available at /Users/dkinni/go/src/github.com/vmware-tanzu/astrolabe
building: _output/bin/linux/amd64/velero-plugin-for-vsphere
/Library/Developer/CommandLineTools/usr/bin/make shell CMD="-c '\
                GOOS=linux \
                GOARCH=amd64 \
                REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni \
                VERSION=rem_metric_port_v1 \
                PKG=github.com/vmware-tanzu/velero-plugin-for-vsphere \
                BIN=velero-plugin-for-vsphere \
                GIT_SHA=0d8dd16add9baf258847b8853e982c1c9c234994 \
                GIT_DIRTY=\"\" \
                OUTPUT_DIR=/output/linux/amd64 \
                GO111MODULE=on \
                GOFLAGS=-mod=readonly \
                ./hack/build.sh'"
running docker: shell
docker run \
                --platform linux/amd64 \
                -e GOFLAGS \
                -i -t \
                --rm \
                -u $(id -u):$(id -g) \
                -v $(pwd)/.libs/vmware-vix-disklib-distrib:/usr/local/vmware-vix-disklib-distrib:delegated \
                -v $(pwd)/.go/pkg:/go/pkg:delegated \
                -v $(pwd)/.go/src:/go/src:delegated \
                -v $(pwd)/.go/std:/go/std:delegated \
                -v $(pwd):/go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere:delegated \
                -v "$(pwd)/_output/bin:/output:delegated" \
                -v $(pwd)/.go/std/linux/amd64:/usr/local/go/pkg/linux/amd64_static:delegated \
                -v "$(pwd)/.go/go-build:/.cache/go-build:delegated" \
                -e CGO_ENABLED=1 \
                -e GOPATH=/go \
                -w /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere \
                golang:1.18 \
                /bin/sh -c '    GOOS=linux      GOARCH=amd64    REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni         VERSION=rem_metric_port_v1      PKG=github.com/vmware-tanzu/velero-plugin-for-vsphere   BIN=velero-plugin-for-vsphere   GIT_SHA=0d8dd16add9baf258847b8853e982c1c9c234994       GIT_DIRTY=""     OUTPUT_DIR=/output/linux/amd64  GO111MODULE=on  GOFLAGS=-mod=readonly   ./hack/build.sh'
making: vsphere-astrolabe
/Library/Developer/CommandLineTools/usr/bin/make build BIN=vsphere-astrolabe VERSION=rem_metric_port_v1
skip copying astrolabe as it is not available at /Users/dkinni/go/src/github.com/vmware-tanzu/astrolabe
building: _output/bin/linux/amd64/vsphere-astrolabe
/Library/Developer/CommandLineTools/usr/bin/make shell CMD="-c '\
                GOOS=linux \
                GOARCH=amd64 \
                REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni \
                VERSION=rem_metric_port_v1 \
                PKG=github.com/vmware-tanzu/velero-plugin-for-vsphere \
                BIN=vsphere-astrolabe \
                GIT_SHA=0d8dd16add9baf258847b8853e982c1c9c234994 \
                GIT_DIRTY=\"\" \
                OUTPUT_DIR=/output/linux/amd64 \
                GO111MODULE=on \
                GOFLAGS=-mod=readonly \
                ./hack/build.sh'"
running docker: shell
docker run \
                --platform linux/amd64 \
                -e GOFLAGS \
                -i -t \
                --rm \
                -u $(id -u):$(id -g) \
                -v $(pwd)/.libs/vmware-vix-disklib-distrib:/usr/local/vmware-vix-disklib-distrib:delegated \
                -v $(pwd)/.go/pkg:/go/pkg:delegated \
                -v $(pwd)/.go/src:/go/src:delegated \
                -v $(pwd)/.go/std:/go/std:delegated \
                -v $(pwd):/go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere:delegated \
                -v "$(pwd)/_output/bin:/output:delegated" \
                -v $(pwd)/.go/std/linux/amd64:/usr/local/go/pkg/linux/amd64_static:delegated \
                -v "$(pwd)/.go/go-build:/.cache/go-build:delegated" \
                -e CGO_ENABLED=1 \
                -e GOPATH=/go \
                -w /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere \
                golang:1.18 \
                /bin/sh -c '    GOOS=linux      GOARCH=amd64    REGISTRY=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni         VERSION=rem_metric_port_v1      PKG=github.com/vmware-tanzu/velero-plugin-for-vsphere   BIN=vsphere-astrolabe   GIT_SHA=0d8dd16add9baf258847b8853e982c1c9c234994        GIT_DIRTY=""    OUTPUT_DIR=/output/linux/amd64  GO111MODULE=on  GOFLAGS=-mod=readonly   ./hack/build.sh'
cp $(pwd)/scripts/install.sh _output/bin/linux/amd64
/Library/Developer/CommandLineTools/usr/bin/make build-container IMAGE=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/velero-plugin-for-vsphere DOCKERFILE=Dockerfile-plugin VERSION=rem_metric_port_v1
mkdir -p _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64
cp -R /Users/dkinni/go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere/.libs/vmware-vix-disklib-distrib/lib64/* _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64
# Some of the libraries have the executable bit set and this causes plugin startup to fail
chmod 644 _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64/*
container: cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/velero-plugin-for-vsphere:rem_metric_port_v1
cp Dockerfile-plugin _output/bin/linux/amd64/Dockerfile-plugin
docker build --platform linux/amd64 -t cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/velero-plugin-for-vsphere:rem_metric_port_v1 -f _output/bin/linux/amd64/Dockerfile-plugin _output
[+] Building 14.7s (14/14) FINISHED                                                                                                                                                                                                                                                                docker:desktop-linux
 => [internal] load build definition from Dockerfile-plugin                                                                                                                                                                                                                                                        0.0s
 => => transferring dockerfile: 1.03kB                                                                                                                                                                                                                                                                             0.0s
 => [internal] load metadata for docker.io/library/photon:5.0                                                                                                                                                                                                                                                      1.8s
 => [auth] library/photon:pull token for registry-1.docker.io                                                                                                                                                                                                                                                      0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                                                                  0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                                                                    0.0s
 => [1/8] FROM docker.io/library/photon:5.0@sha256:027f9eed364392f9abf8a60fea5e6883d7b4b6a66d09e822de10a734eb9bb6a0                                                                                                                                                                                                0.0s
 => => resolve docker.io/library/photon:5.0@sha256:027f9eed364392f9abf8a60fea5e6883d7b4b6a66d09e822de10a734eb9bb6a0                                                                                                                                                                                                0.0s
 => [internal] load build context                                                                                                                                                                                                                                                                                  3.1s
 => => transferring context: 311.96MB                                                                                                                                                                                                                                                                              3.0s
 => CACHED [2/8] RUN tdnf -y upgrade && tdnf clean all                                                                                                                                                                                                                                                             0.0s
 => [3/8] ADD /bin/linux/amd64/velero-* /plugins/                                                                                                                                                                                                                                                                  0.3s
 => [4/8] ADD /bin/linux/amd64/data-* /                                                                                                                                                                                                                                                                            0.2s
 => [5/8] ADD /bin/linux/amd64/backup-driver* /                                                                                                                                                                                                                                                                    0.1s
 => [6/8] COPY /bin/linux/amd64/install.sh /scripts/                                                                                                                                                                                                                                                               0.0s
 => [7/8] COPY /bin/linux/amd64/lib/vmware-vix-disklib/lib64/* /plugins/                                                                                                                                                                                                                                           0.2s
 => [8/8] RUN ["chmod", "+x", "/scripts/install.sh"]                                                                                                                                                                                                                                                               0.2s
 => exporting to image                                                                                                                                                                                                                                                                                             6.3s
 => => exporting layers                                                                                                                                                                                                                                                                                            4.3s
 => => exporting manifest sha256:e3c4430b36f6ffc3bf7d7e8efe843f37573690c8310882cfe575920aa687ef6a                                                                                                                                                                                                                  0.0s
 => => exporting config sha256:ae3999b70e0be3c53344d38acb4ea11f47c9f8cc9a2179af949f0b6e8236a100                                                                                                                                                                                                                    0.0s
 => => exporting attestation manifest sha256:ad58055746139fb1ca4a075045cacb5eefd8873afef97fab15326aba16b4bd40                                                                                                                                                                                                      0.0s
 => => exporting manifest list sha256:9e20b98c4673c3915f045e9e84f804f0981af4e368050f4c192c9c37605ba13b                                                                                                                                                                                                             0.0s
 => => naming to cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/velero-plugin-for-vsphere:rem_metric_port_v1                                                                                                                                                                                               0.0s
 => => unpacking to cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/velero-plugin-for-vsphere:rem_metric_port_v1                                                                                                                                                                                            1.9s

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/jqgqo3cgvr8714x5ptrlyfghr

What's next:
    View a summary of image vulnerabilities and recommendations → docker scout quickview 
/Library/Developer/CommandLineTools/usr/bin/make build-container BIN=data-manager-for-plugin IMAGE=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/data-manager-for-plugin DOCKERFILE=Dockerfile-datamgr VERSION=rem_metric_port_v1
mkdir -p _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64
cp -R /Users/dkinni/go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere/.libs/vmware-vix-disklib-distrib/lib64/* _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64
# Some of the libraries have the executable bit set and this causes plugin startup to fail
chmod 644 _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64/*
container: cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/data-manager-for-plugin:rem_metric_port_v1
cp Dockerfile-datamgr _output/bin/linux/amd64/Dockerfile-datamgr
docker build --platform linux/amd64 -t cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/data-manager-for-plugin:rem_metric_port_v1 -f _output/bin/linux/amd64/Dockerfile-datamgr _output
[+] Building 7.1s (9/9) FINISHED                                                                                                                                                                                                                                                                   docker:desktop-linux
 => [internal] load build definition from Dockerfile-datamgr                                                                                                                                                                                                                                                       0.0s
 => => transferring dockerfile: 822B                                                                                                                                                                                                                                                                               0.0s
 => [internal] load metadata for docker.io/library/photon:5.0                                                                                                                                                                                                                                                      0.6s
 => [internal] load .dockerignore                                                                                                                                                                                                                                                                                  0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                                                                    0.0s
 => [1/4] FROM docker.io/library/photon:5.0@sha256:027f9eed364392f9abf8a60fea5e6883d7b4b6a66d09e822de10a734eb9bb6a0                                                                                                                                                                                                0.0s
 => => resolve docker.io/library/photon:5.0@sha256:027f9eed364392f9abf8a60fea5e6883d7b4b6a66d09e822de10a734eb9bb6a0                                                                                                                                                                                                0.0s
 => [internal] load build context                                                                                                                                                                                                                                                                                  0.7s
 => => transferring context: 62.27MB                                                                                                                                                                                                                                                                               0.7s
 => CACHED [2/4] RUN tdnf -y upgrade && tdnf clean all                                                                                                                                                                                                                                                             0.0s
 => [3/4] ADD /bin/linux/amd64/data-* /datamgr                                                                                                                                                                                                                                                                     0.4s
 => [4/4] COPY /bin/linux/amd64/lib/vmware-vix-disklib/lib64/* /vddkLibs/                                                                                                                                                                                                                                          0.2s
 => exporting to image                                                                                                                                                                                                                                                                                             5.1s
 => => exporting layers                                                                                                                                                                                                                                                                                            4.2s
 => => exporting manifest sha256:ae5c3ecb263e6efae6f1c3ac4c1cff0058f7d668db43efa66372a91a020e832a                                                                                                                                                                                                                  0.0s
 => => exporting config sha256:16a77b40610eef13cadc16785ced826a90b5e2633c84cdd786bc12603ce63b71                                                                                                                                                                                                                    0.0s
 => => exporting attestation manifest sha256:15188b2ba57ef53cc2330c5a5ada9e5c0bd8ca8aaec2f7ace523904c2a126fd1                                                                                                                                                                                                      0.0s
 => => exporting manifest list sha256:8d50696d79e11183f5a2b676fbcb85e8beb0ef3d8a0cf77097a786e771522457                                                                                                                                                                                                             0.0s
 => => naming to cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/data-manager-for-plugin:rem_metric_port_v1                                                                                                                                                                                                 0.0s
 => => unpacking to cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/data-manager-for-plugin:rem_metric_port_v1                                                                                                                                                                                              0.9s

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/wjvxe8d8rlgcz2elt29elhkeh

What's next:
    View a summary of image vulnerabilities and recommendations → docker scout quickview 
/Library/Developer/CommandLineTools/usr/bin/make build-container BIN=backup-driver IMAGE=cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/backup-driver DOCKERFILE=Dockerfile-backup-driver VERSION=rem_metric_port_v1
mkdir -p _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64
cp -R /Users/dkinni/go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere/.libs/vmware-vix-disklib-distrib/lib64/* _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64
# Some of the libraries have the executable bit set and this causes plugin startup to fail
chmod 644 _output/bin/linux/amd64/lib/vmware-vix-disklib/lib64/*
container: cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/backup-driver:rem_metric_port_v1
cp Dockerfile-backup-driver _output/bin/linux/amd64/Dockerfile-backup-driver
docker build --platform linux/amd64 -t cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/backup-driver:rem_metric_port_v1 -f _output/bin/linux/amd64/Dockerfile-backup-driver _output
[+] Building 6.6s (9/9) FINISHED                                                                                                                                                                                                                                                                   docker:desktop-linux
 => [internal] load build definition from Dockerfile-backup-driver                                                                                                                                                                                                                                                 0.0s
 => => transferring dockerfile: 841B                                                                                                                                                                                                                                                                               0.0s
 => [internal] load metadata for docker.io/library/photon:5.0                                                                                                                                                                                                                                                      0.7s
 => [internal] load .dockerignore                                                                                                                                                                                                                                                                                  0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                                                                    0.0s
 => [1/4] FROM docker.io/library/photon:5.0@sha256:027f9eed364392f9abf8a60fea5e6883d7b4b6a66d09e822de10a734eb9bb6a0                                                                                                                                                                                                0.0s
 => => resolve docker.io/library/photon:5.0@sha256:027f9eed364392f9abf8a60fea5e6883d7b4b6a66d09e822de10a734eb9bb6a0                                                                                                                                                                                                0.0s
 => [internal] load build context                                                                                                                                                                                                                                                                                  1.5s
 => => transferring context: 142.48MB                                                                                                                                                                                                                                                                              1.5s
 => CACHED [2/4] RUN tdnf -y upgrade && tdnf clean all                                                                                                                                                                                                                                                             0.0s
 => CACHED [3/4] COPY /bin/linux/amd64/lib/vmware-vix-disklib/lib64/* /vddkLibs/                                                                                                                                                                                                                                   0.0s
 => [4/4] ADD /bin/linux/amd64/backup-driver* /backup-driver                                                                                                                                                                                                                                                       0.6s
 => exporting to image                                                                                                                                                                                                                                                                                             3.7s
 => => exporting layers                                                                                                                                                                                                                                                                                            3.2s
 => => exporting manifest sha256:e16cdd933c58001b2a53eb18e4a297e5a203c7b885914a7ae0fb1dd2d1a60022                                                                                                                                                                                                                  0.0s
 => => exporting config sha256:b66fd99b4501373aca11f64e3ebb89e7c0a946ec46d3994077f3328bf516179f                                                                                                                                                                                                                    0.0s
 => => exporting attestation manifest sha256:bba2d19d47f1e63d66caaf45bd6129ee5711867c051a8040a5630d1156573508                                                                                                                                                                                                      0.0s
 => => exporting manifest list sha256:567f11e0d0a3c798e3f9b3d44f1e4ff5083c96a773233f5b0bf7f0d8959e805b                                                                                                                                                                                                             0.0s
 => => naming to cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/backup-driver:rem_metric_port_v1                                                                                                                                                                                                           0.0s
 => => unpacking to cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/backup-driver:rem_metric_port_v1

Installed on Supervisor:

root@420eaa73f3809ee9cb625cd3af7f353a [ ~ ]# kubectl -n test-velero-service-404 get pods
NAME                             READY   STATUS    RESTARTS   AGE
backup-driver-6f8846bb75-hxspw   1/1     Running   0          25s
nginx-v1                         1/1     Running   0          79m
velero-555444675b-g72kf          1/1     Running   0          95s

Does this PR introduce a user-facing change?:
None

Signed-off-by: Deepak Kinni <deepak.kinni@broadcom.com>

xing-yang · 2025-01-15T18:56:38Z

Have you tested this on vSphere?

deepakkinni · 2025-01-16T00:29:12Z

Have you tested this on vSphere?

Yes. All the Pods are up

root@420eaa73f3809ee9cb625cd3af7f353a [ ~ ]# kubectl -n test-velero-service-404 get pods
NAME                             READY   STATUS    RESTARTS   AGE
backup-driver-6f8846bb75-hxspw   1/1     Running   0          25s
nginx-v1                         1/1     Running   0          79m
velero-555444675b-g72kf          1/1     Running   0          95s

xing-yang · 2025-01-16T14:52:22Z

Can you print out the deployment yaml? We want to make sure the metrics port is not referenced there.

deepakkinni · 2025-01-16T19:07:38Z

Can you print out the deployment yaml? We want to make sure the metrics port is not referenced there.

root@420eaa73f3809ee9cb625cd3af7f353a [ ~ ]# kubectl -n test-velero-service-404 get deploy backup-driver -oyaml
apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
  creationTimestamp: "2025-01-16T00:27:10Z"
  generation: 1
  labels:
    component: velero
  name: backup-driver
  namespace: test-velero-service-404
  ownerReferences:
  - apiVersion: veleroappoperator.vmware.com/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: VeleroService
    name: default
    uid: bbf95560-c2e1-44dc-b46b-534370569161
  resourceVersion: "6699269"
  uid: 8449647f-82cb-40ce-b4be-f03aa5541c70
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      name: backup-driver
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        component: velero
        name: backup-driver
    spec:
      containers:
      - args:
        - server
        command:
        - /backup-driver
        env:
        - name: NODE_NAME
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: spec.nodeName
        - name: VELERO_NAMESPACE
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
        - name: VELERO_SCRATCH_DIR
          value: /scratch
        - name: LD_LIBRARY_PATH
          value: /vddkLibs
        image: cns-docker-dev-local.usw5.packages.broadcom.com/dkinni/backup-driver:rem_metric_port_v1
        imagePullPolicy: IfNotPresent
        name: backup-driver
        resources: {}
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
        volumeMounts:
        - mountPath: /scratch
          name: scratch
      dnsPolicy: ClusterFirst
      hostNetwork: true
      nodeSelector:
        node-role.kubernetes.io/control-plane: ""
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext:
        runAsUser: 0
      serviceAccount: velero
      serviceAccountName: velero
      terminationGracePeriodSeconds: 30
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/master
        operator: Exists
      - effect: NoSchedule
        key: node-role.kubernetes.io/control-plane
        operator: Exists
      - effect: NoSchedule
        key: kubeadmNode
        operator: Equal
        value: master
      volumes:
      - emptyDir: {}
        name: scratch
status:
  availableReplicas: 1
  conditions:
  - lastTransitionTime: "2025-01-16T00:27:12Z"
    lastUpdateTime: "2025-01-16T00:27:12Z"
    message: Deployment has minimum availability.
    reason: MinimumReplicasAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2025-01-16T00:27:10Z"
    lastUpdateTime: "2025-01-16T00:27:12Z"
    message: ReplicaSet "backup-driver-6f8846bb75" has successfully progressed.
    reason: NewReplicaSetAvailable
    status: "True"
    type: Progressing
  observedGeneration: 1
  readyReplicas: 1
  replicas: 1
  updatedReplicas: 1

xing-yang

lgtm

Remove metrics port from backup-driver deployment

6bf102f

Signed-off-by: Deepak Kinni <deepak.kinni@broadcom.com>

deepakkinni force-pushed the topic/deepakkinni/rem_metric_port_v1 branch from 0d8dd16 to 6bf102f Compare January 14, 2025 21:16

xing-yang approved these changes Jan 16, 2025

View reviewed changes

xing-yang merged commit ed30541 into vmware-tanzu:main Jan 16, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove metrics port from backup-driver deployment #601

Remove metrics port from backup-driver deployment #601

deepakkinni commented Jan 14, 2025 •

edited

Loading

xing-yang commented Jan 15, 2025

deepakkinni commented Jan 16, 2025

xing-yang commented Jan 16, 2025

deepakkinni commented Jan 16, 2025

xing-yang left a comment

Remove metrics port from backup-driver deployment #601

Remove metrics port from backup-driver deployment #601

Conversation

deepakkinni commented Jan 14, 2025 • edited Loading

xing-yang commented Jan 15, 2025

deepakkinni commented Jan 16, 2025

xing-yang commented Jan 16, 2025

deepakkinni commented Jan 16, 2025

xing-yang left a comment

Choose a reason for hiding this comment

deepakkinni commented Jan 14, 2025 •

edited

Loading