Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

added namespace config to edit screen #89

Merged
merged 2 commits into from
Apr 13, 2020

Conversation

georgekaz
Copy link
Contributor

@georgekaz georgekaz commented Apr 8, 2020

As per #70 (comment)
and vmware-archive/kubeless#1015 (comment)

  1. I've added a namespace option to the editor screen (src/components/Func/FuncParams.js)
  2. Changed the default namespace from "default" to "kubeless" to match the kubeless cli behaviour (src/utils/EntityHelper.js)
  3. Probably pointlessly fixed the Dockerfile-prod. I don't know why it was there but it didn't build. Now it does.

No additional tests added but I've built and tested the image and the results are as expected.

Please consider this PR in lieu of that fact several people have requested this feature. Thanks

@georgekaz georgekaz force-pushed the add-namespace-to-editor branch from 023e87a to 4f7c1fb Compare April 9, 2020 11:02
@georgekaz
Copy link
Contributor Author

@andresmgot would you be able to review this please? Thanks

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @georgekaz !

@andresmgot andresmgot merged commit 63c80d6 into vmware-archive:master Apr 13, 2020
@georgekaz georgekaz deleted the add-namespace-to-editor branch April 14, 2020 09:42
@georgekaz
Copy link
Contributor Author

thanks for merging @andresmgot . Could we update the creds on circleci so that the docker image can be updated please? The build is failing because it's unable to push the updated image. https://circleci.com/gh/kubeless/kubeless-ui/150

@andresmgot
Copy link
Contributor

thanks for the heads up! I have updated those credentials, the image should be published now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants