-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add tests for zkfs
utilities
#15002
Conversation
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15002 +/- ##
========================================
Coverage 47.33% 47.33%
========================================
Files 1142 1143 +1
Lines 239009 239109 +100
========================================
+ Hits 113125 113191 +66
- Misses 117289 117321 +32
- Partials 8595 8597 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Description
vitess/go/cmd/zk/internal/zkfs
zk2topo.ZkConn
in a simple manner for testing. If anyone can point me to any files that might have done the same previously, or give me some clue as to how we might go about it (without defining all the required methods explicitly), I would love to update the PR to handle the same as well.Related Issue(s)
Fixes part of #14931