VTAdmin: Add advanced workflow switchtraffic options (#17658)

Signed-off-by: Noble Mittal <noblemittal@outlook.com>
vitessio · Feb 25, 2025 · afdb26b · afdb26b
1 parent 82d21e5
commit afdb26b
Show file tree

Hide file tree

Showing 7 changed files with 667 additions and 46 deletions.
diff --git a/go/vt/vtadmin/api.go b/go/vt/vtadmin/api.go
@@ -2878,16 +2878,6 @@ func (api *API) WorkflowSwitchTraffic(ctx context.Context, req *vtadminpb.Workfl
 		return nil, err
 	}
 
-	// Set the default options which are not supported in VTAdmin Web.
-	req.Request.TabletTypes = []topodatapb.TabletType{
-		topodatapb.TabletType_PRIMARY,
-		topodatapb.TabletType_REPLICA,
-		topodatapb.TabletType_RDONLY,
-	}
-	req.Request.Timeout = protoutil.DurationToProto(workflow.DefaultTimeout)
-	req.Request.MaxReplicationLagAllowed = protoutil.DurationToProto(vreplcommon.MaxReplicationLagDefault)
-	req.Request.EnableReverseReplication = true
-
 	return c.Vtctld.WorkflowSwitchTraffic(ctx, req.Request)
 }
 

diff --git a/web/vtadmin/src/components/dialog/Dialog.tsx b/web/vtadmin/src/components/dialog/Dialog.tsx
@@ -119,6 +119,7 @@ const Dialog: React.FC<DialogProps> = ({
                                             disabled={loading}
                                             type="button"
                                             className="btn"
+                                            data-testid="confirm-btn"
                                             onClick={() => {
                                                 onConfirm?.();
                                             }}

diff --git a/web/vtadmin/src/components/dropdown/Dropdown.tsx b/web/vtadmin/src/components/dropdown/Dropdown.tsx
@@ -32,6 +32,7 @@ export const DropdownButton: React.FC<{ icon: Icons; title?: string; className?:
             className
         )}
         id="menu-button"
+        data-testid="dropdown-btn"
         aria-haspopup="true"
         aria-label={title || 'change'}
         title={title || 'change'}