Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pypi-publish action #110

Closed
wants to merge 3 commits into from

Conversation

kushalkolar
Copy link
Contributor

adds pypi publish action, you'll need to add the PYPI_API_TOKEN secret to the repo though.

@almarklein
Copy link
Member

This is actually done by the release.py script, but when I ran it a few days ago, the pypi upload failed and I did not see:

Uploading distributions to https://upload.pypi.org/legacy/
ERROR    InvalidDistribution: Metadata is missing required fields: Name, Version.
         Make sure the distribution includes the files where those fields are specified, and is using a supported Metadata-Version: 1.0, 1.1, 1.2, 2.0, 2.1, 2.2, 2.3.
Success!

That last "Success" was wrong 😕

@kushalkolar
Copy link
Contributor Author

This is actually done by the release.py script, but when I ran it a few days ago, the pypi upload failed and I did not see:

Ah I didn't notice that! Curious, is this something you run locally or does it run on a build server?

That last "Success" was wrong 😕

😆

@almarklein
Copy link
Member

I just run it locally. If something goes wrong its easier to fix and adjust.

Looks like the pypi upload is not the only thing that went wrong. Looks like not all changed version numbers were actually comitted ... oh boy

@almarklein
Copy link
Member

I fixed the script and re-released 😅

@almarklein almarklein closed this Jan 17, 2025
@almarklein
Copy link
Member

Thanks for the effort. The idea to automate this step is tempting, but I rather do the whole release process either completely locally or completely on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants