fix: use correct display coordinates #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's probably being inlined anyway but using `into_storage` removes a layer of unnecessary indirection.
|
I'm going to close this now in favor of a new PR which includes some additional performance work and API changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vexDisplayCopyRecttakes the top left and bottom right points to be copied, not the rect height. This PR adjusts the bottom right point to be correct.Additionally, I changed the color conversion code to use
into_storagewhich does a zero-copy cast tou32instead of the old method which goes through anrgb::Rgb.