-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/image link #87
Feat/image link #87
Conversation
…pups there needs access to context
…n they were not rendered
I do have some major performance problems (I belive it is only client side) in the infinite scroll of images. This is not anything new though |
Again, i'm having issues with scaling. I can't see the bottom row of image collections when picking a new image. I think we need to find a way to address this as it is becoming a common issue. I think it stems from the fact that you're mac has a larger screen/different scaling than my computer. We need to account better for users having diffrent sizes and/or scaling on their screens. |
Could you elaborate on that? Do you mean ifinite scroll when view a collection? I don't think i have seen any performance issues (not directly related to my computer that is) when it comes to images. At least not with just the few default images. |
I'll fix this before the meeting. Well all UI obviously needs review like this. We probably need to make sure people develope on different browsers. I'll take note of that |
It is for displaying images (at least for now, there are usually not many collections to display) |
But I will fix those performance issues in a later patch, as well some other small problems |
Just an idea, and not really related to the pr, but wouldn't "album" be a better name for "image collection"? |
Understood. |
… on hover in ImageLinkEditor
The ui for picture selection works on my pc now. I still think the scaling is a bit too big as I need a scroll bar for two rows of pictures, but that's no biggie. Would like to post a picture but im on mobile rn. But this is something that can be tuned later. |
Ha to changehowpopupsworked too.
They are now more flexible in that you can define where the popups should mount in the dom. by using providers