Improve rustfmt.toml support
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it would pick up from the cwd or ancestors, which can be surprising (and also goes against what rustfmt itself does); with this commit, we explicitly do the same sort of search that rustfmt does, and pick up the correct rustfmt.toml, thereby making our execution independent of where we ran from
parno
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things related to
rustfmt.toml, categorized into stuff that is user-facing, and library API changes.This should help unblock one major part of #46
User-Facing Changes
rustfmt.tomlfor non-verus!coderustfmt.tomlbased on working directory, it is now picked up based on the file being formatted. This now matches the search thatrustfmtitself does.Public verusfmt-as-library API
These changes should basically impact nobody, unless they are depending on verusfmt as a library (unlikely, but technically possible; my guess is that only our test code is the user of verusfmt as a library, with everyone else using it as an executable). Nonetheless, listing them here since they are technically changing the library API.
parse_and_formatfrom the public library APIverusfmt::runrustfmt.tomlvia the public library APINote: auto-merge for this PR on accepted-review is enabled.