Add more files in examples/ to CI
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybosamiya
force-pushed
the
snapshot-examples
branch
from
24a0040 to
e5d9e1d
Compare
parno
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up more files from
examples/to be run on CI.Since we didn't have these on CI, there was a regression in the parser that is also fixed in this PR.
Also, if the snapshot test for
syntax.rsfails, we now get a nicer output (using a unified diff), rather than just dumping everything.The mimalloc and nr examples suffer from issues when snapshot testing, so I've added them as ignored tests with reminders of why. However, we should not block this PR on fixing that, so that at least we start getting the CI checks on the rest.