MCSS-83: Refactor About Section #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
✅ Deploy Preview for mcss-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
anthonytedja
reviewed
Oct 2, 2023
components/Home/AboutUsSection.tsx
Outdated
Comment on lines
11
to
19
| const theme = createTheme({ | ||
| typography: { | ||
| fontFamily: ['Segoe UI'].join(','), | ||
| }, | ||
| }); | ||
|
|
||
| const AboutUsSection: FC = () => ( | ||
| <div | ||
| id="about" | ||
| className="about-us-section flex flex-col items-center lg:items-stretch lg:flex-row gap-8" | ||
| > | ||
| <div className="header-img w-full lg:w-1/3 lg:min-h-full hidden lg:block"> | ||
| <Image | ||
| src={Deerfield} | ||
| alt="Deerfield Hall" | ||
| className="min-h-full rounded-lg overflow-hidden" | ||
| draggable="false" | ||
| /> | ||
| </div> | ||
| <div className="w-4/5 mt-10 lg:mt-0 lg:w-2/3 flex flex-col justify-between xl:justify-center"> | ||
| <span> | ||
| <p className="inline-block h-1/3 mr-5 text-2xl">ABOUT US</p> | ||
| <hr className="inline-block h-1 w-56 bg-purple-600" /> | ||
| </span> | ||
| <div className="flex items-center my-5 lg:my-0"> | ||
| <div className="w-1/2"> | ||
| <p className="text-2xl md:text-4xl mt-3 mb-3 lg:text-6xl font-bold">FOR THE STUDENTS</p> | ||
| <p className="lg:hidden text-lg text-purple-700 font-semibold">Academic Society</p> | ||
| <ThemeProvider theme={theme}> | ||
| <Container |
There was a problem hiding this comment.
as for the theme, we already have a theme defined in the themes file so we can unify the theming throughout the app
|
Fixed all the mentioned issues |
| </div> | ||
| </div> | ||
| </div> | ||
| <ThemeProvider theme={aboutSectionTheme}> |
There was a problem hiding this comment.
we should be using / modifying the 1 theme that we use throughout the app instead of creating multiple theme instances
| FOR THE STUDENTS | ||
| </Typography> | ||
| </Box> | ||
| <Box className="md:block w-1/4 md:w-1/6 m-auto hidden"> |
There was a problem hiding this comment.
the end goal is to remove tailwind and use the theme styling / sx inline overrides so we should remove references to tailwind classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Inside
... full details of acceptance criteria documented in the linked GitHub issue