chore: Use dedicated service for metrics #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlx
requested changes
Apr 19, 2024
| {{- end }} | ||
| name: {{ include "lagoon-logs-concentrator.fullname" . }}-metrics | ||
| labels: | ||
| service: metrics |
There was a problem hiding this comment.
As discussed, maybe this should be updated to metrics-only=true to match the other charts? But I'm not too fussed. Just whatever is most consistent with other servicemonitor selectors.
There was a problem hiding this comment.
Updated it so that it aligns with the other charts in this repository.
| @@ -19,7 +19,7 @@ type: application | |||
| # time you make changes to the chart and its templates, including the app | |||
| # version. | |||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | |||
| version: 0.47.0 | |||
| version: 0.48.0 | |||
|
|
|||
| # This section is used to collect a changelog for artifacthub.io | |||
There was a problem hiding this comment.
The CI failure is due to this field not being updated. This field must be updated on every PR because it generates the changelog on artifacthub. The format is documented here.
When the main service is used as a load balancer service to allow public access through mTLS, the metrics should not be exposed on the same service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the main service is used as a load balancer service to allow public
access through mTLS, the metrics should not be exposed on the same
service.