fix(website): offer to switch to right safe chain #1021
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e0e85f8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
in the video you shared, the button appears to un-disable after the switch chain is completed? Shouldnt it continue to be disabled/loading until its done?
also, can we turn this more or less repeated section of code into a helper function? I have a feeling we are going to be using similar pattern a lot.
Ignusmart
force-pushed
the
fix/offer-to-switch
branch
2 times, most recently
from
26eb08f to
a68de3e
Compare
| @@ -380,12 +380,15 @@ export const QueuedTxns = ({ | |||
| colorScheme="teal" | |||
| w="100%" | |||
| isDisabled={ | |||
| stager.signing || | |||
There was a problem hiding this comment.
in accordance with showing a reason any time a button is disabled, can we put some indication somewhere... somehow on the page that says "currently signing txn" to indicate the button is disabled (maybe the user doenst realize their signing window was opened when they click on the button)
There was a problem hiding this comment.
Nice catch, sure, I'll add it ASAP, thank you
Ignusmart
force-pushed
the
fix/offer-to-switch
branch
from
37105e6 to
e0e85f8
Compare
The main purpose of this PR is to offer the user to switch to the right chain before executing/staging any transaction
Screen.Recording.2024-05-17.at.8.35.42.AM.mov