-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server)!: rename .func() to .handler() #60
Conversation
More templates
@orpc/client
@orpc/next
@orpc/contract
@orpc/openapi
@orpc/react
@orpc/react-query
@orpc/server
@orpc/shared
@orpc/vue-query
@orpc/zod
commit: |
oRPC start with But it only is my opinion, and English is not my first language so I will carefully consider it |
|
I think that's completely fine to have still because it still runs on the basis of "this is the function/codeblock that handles the logic", like OpenAPIHandler handles that specifically and you know that middleware will do that. |
@unteifu please resolve conflict, and go to |
I've just merged the docs update with this branch as it means the docs will be up to date with this commit then and also pass CI |
I think the
.func()
function should be renamed to.handler()
as visually it doesn't make sense at first and looks very vague, this was something I found confusing when I first saw the docs. Calling it.handler()
means developers, know ok this is what will be the endpoints main handling logic after all middleware and validation.