Fix force scrolling to the top repeatedly when use 'Always use "Follwing" Tab' #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wing" Tab' is enabled in non-English locale The original implementation uses the string literal "following" to detect the "Following" tab, but the string is localized to some strings in a non-English locale. In this commit, use localized "following" text from DOM to check "following" tab is selected. fix typefully#209, typefully#206
|
Thanks for this @mactkg, I don't have this problem having X in English but the change makes sense to me. I'll implement this myself for the next update with a small tweak. |
|
Thanks for your review. I'm look forward to fix this issue! |
|
Agh, already fixed :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation uses the literal "following" string to detect the "Following" tab, but the string is localized to some strings in a non-English locale.
For instance, the "Following" tab is localized to "フォロー中" in Japanese locale.
In this PR, use localized "following" text from DOM to check "following" tab is selected.
fix #209, #206