KIP-848: The next generation consumer group protocol #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the rebalance is triggered from the leader noticing a metadata update, well, we just noticed it; no need for a metadata update * Kafka prefers keeping leaders across rebalances * If we are chosen to be a follower, well, we will update our metadata when we are assigned a partition we do not know of * If we are a leader and are missing a partition, we'll eventually notice it and a few minutes later cause a rebalance This essentially removes a niche optimization in favor of hammering brokers less with metadata requests. Also removes some wording from logs in preparation of these same logs being used in a non-rejoin context.
In prep for consumer group heartbeat request.
Linting on GH is currently broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically opts into the next gen group if
This only supports v0 ConsumerGroupHeartbeat at the moment; v1 will come in the next kmsg bump, which will be before v1.19.