@tus/server: make upload-offset a string

[hoiekim]

Resolves #751 by simply converting the type of "Upload-Offset" header value from number to string.

[changeset-bot]

🦋 Changeset detected

Latest commit: 89edc80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@tus/server	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This change updates the response header setting in the PatchHandler class. The numeric newOffset value is now explicitly converted to a string before being assigned to the Upload-Offset header. The modification ensures that the header value adheres to the HTTP specification that requires all header values to be strings, without altering the overall method logic or introducing new error handling.

Changes

File	Change Summary
packages/.../PatchHandler.ts	Converted newOffset from a number to a string using toString() for the Upload-Offset header assignment.
.changeset/happy-countries-ring.md	Created new file documenting a patch version update for "@tus/server" with a note on the "upload-offset" header.

Assessment against linked issues

Objective	Addressed	Explanation
Value of "Upload-Offset" header should be string (#751)	✅

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a67eb1a and 89edc80.

📒 Files selected for processing (1)

• .changeset/happy-countries-ring.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• .changeset/happy-countries-ring.md

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.changeset/happy-countries-ring.md (1)

5-5: Refine the Fix Description

The commit message "fix bug: upload-offset header should be string" accurately reflects the change. For improved clarity and grammatical consistency, consider adding the article "a" before "string". If you agree, you might update it as follows:

-fix bug: upload-offset header should be string
+fix bug: upload-offset header should be a string

Note: The static analysis hint from LanguageTool appears to be a false positive in this context—please disregard it if the message remains clear.

🧰 Tools

🪛 LanguageTool

[grammar] ~5-~5: Did you mean “strung”?
Context: ...fix bug: upload-offset header should be string

(SHOULD_BE_DO)

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d26b0b2 and a67eb1a.

📒 Files selected for processing (2)

• .changeset/happy-countries-ring.md (1 hunks)
• packages/server/src/handlers/PatchHandler.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/server/src/handlers/PatchHandler.ts

🧰 Additional context used

🪛 LanguageTool

.changeset/happy-countries-ring.md

[grammar] ~5-~5: Did you mean “strung”?
Context: ...fix bug: upload-offset header should be string

(SHOULD_BE_DO)

🔇 Additional comments (1)

.changeset/happy-countries-ring.md (1)

1-3: Version Bump Documentation Verification

The front matter clearly documents the version update with "@tus/server": minor, which aligns with the intended minor version bump for this bug fix. No issues found here.

[Murderlon]

Thanks