-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/filter favorites #280
Open
laurelbonal
wants to merge
95
commits into
turingschool-examples:main
Choose a base branch
from
KojinKuro:feature/filter-favorites
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/filter favorites #280
laurelbonal
wants to merge
95
commits into
turingschool-examples:main
from
KojinKuro:feature/filter-favorites
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert a recipe object to ingredients array
Adds ingredient ID to name conversion. This is needed so that way we can search what ingredients a recipe has
Use default export
Update with bugfix
Search will check if either the ingredient or the recipe name matches. It matches, it will be filtered through.
updated code
adds function to calculate cost of recipes
Add search capability
Refactor/search tag to use any dataset
Feature/infinite scroll
Fix the merge error
Complete search function
Re-added infinite loading back to the page. Made the filtering function more DRY. Included what was happening in both search event listener and the tags event listeners to make code more DRY.Moved code around to be more readable.
Feature/set single recipe page 2
We have changed findIngredients to using any dataset instead of one. The code has been updated to reflect that. We also use new variables for main. Instead of just having a mainElement, there is now main, mainDirectory, and mainRecipe.
Update recipes-page CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add functionality to filter favorite recipes, checks whether a recipe is favorited and returns only favorited recipes