-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kicad pcb download option #482
Conversation
📊 Bundle Size AnalysisTotal Bundle Size
DiffNo significant changes in bundle size. View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anshgrover23 this is really good work, but can you make it so if they press “download kicad_*” it downloads a zip file containing kicad_pro, kicad_sch and kicad_pcb? These are all required files for kicad. For now, you can just make a zip file containing only the kicad_pcb file if the others arent supported from kicad-converter yet
nice work!!!
@seveibar done |
📊 Bundle Size AnalysisTotal Bundle Size
DiffNo significant changes in bundle size. View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just revert some of the name changes to the copy (text) and functions. Its a kicad project zip file, so "kicad_*.zip" can be the file type
📊 Bundle Size AnalysisTotal Bundle Size
DiffNo significant changes in bundle size. View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
@seveibar can u just clarify you want me to change from this |
@Anshgrover23 the filename should be _kicad.zip, but to hint to the user that it contains different types of kicad files we can have the dropdown display |
@seveibar done. |
📊 Bundle Size AnalysisTotal Bundle Size
DiffNo significant changes in bundle size. View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
📊 Bundle Size AnalysisTotal Bundle Size
DiffNo significant changes in bundle size. View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work /tip $3
🎉🎈 @Anshgrover23 has been awarded $3! 🎈🎊 |
Fixes #481
Reference video:
2025-01-03.21-55-06.mov