Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kicad pcb download option #482

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Conversation

Anshgrover23
Copy link
Contributor

@Anshgrover23 Anshgrover23 commented Jan 3, 2025

Fixes #481

Reference video:

2025-01-03.21-55-06.mov

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 30.11 MB
  • After: 30.15 MB
  • Change: 📈 36.10 KB (0.12%)

Diff

No significant changes in bundle size.

View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 617.30 KB
ms@^2.1.3 530.54 KB
posthog-js@^1.203.2 229.68 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.54 KB
@tscircuit/footprinter@^0.0.96 122.03 KB
circuit-json@^0.0.126 118.90 KB
zod@^3.23.8 117.16 KB
circuit-to-svg@^0.0.99 101.33 KB
tailwind-merge@^2.5.2 69.93 KB
dsn-converter@^0.0.54 32.97 KB
react-helmet@^6.1.0 29.17 KB
fflate@^0.8.2 19.95 KB
states-us@^1.1.1 7.27 KB
use-mouse-matrix-transform@^1.1.13 5.80 KB
zustand@^4.5.5 4.17 KB
file-saver@^2.0.5 3.58 KB
vite@^5.4.8 3.24 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
clsx@^2.1.1 783.00 B
use-async-memo@^1.2.5 759.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
What is this? This is an automated bundle size report generated during the build process.

@Anshgrover23 Anshgrover23 changed the title Add kicad pcb Add kicad pcb download option Jan 3, 2025
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anshgrover23 this is really good work, but can you make it so if they press “download kicad_*” it downloads a zip file containing kicad_pro, kicad_sch and kicad_pcb? These are all required files for kicad. For now, you can just make a zip file containing only the kicad_pcb file if the others arent supported from kicad-converter yet

nice work!!!

@Anshgrover23 Anshgrover23 requested a review from seveibar January 3, 2025 16:26
@Anshgrover23
Copy link
Contributor Author

@seveibar done

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 30.11 MB
  • After: 30.15 MB
  • Change: 📈 36.17 KB (0.12%)

Diff

No significant changes in bundle size.

View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 617.30 KB
ms@^2.1.3 530.54 KB
posthog-js@^1.203.2 229.68 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.54 KB
@tscircuit/footprinter@^0.0.96 122.03 KB
circuit-json@^0.0.126 118.90 KB
zod@^3.23.8 117.16 KB
circuit-to-svg@^0.0.99 101.33 KB
tailwind-merge@^2.5.2 69.93 KB
dsn-converter@^0.0.54 32.97 KB
react-helmet@^6.1.0 29.17 KB
fflate@^0.8.2 19.95 KB
states-us@^1.1.1 7.27 KB
use-mouse-matrix-transform@^1.1.13 5.80 KB
zustand@^4.5.5 4.17 KB
file-saver@^2.0.5 3.58 KB
vite@^5.4.8 3.24 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
clsx@^2.1.1 783.00 B
use-async-memo@^1.2.5 759.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
What is this? This is an automated bundle size report generated during the build process.

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just revert some of the name changes to the copy (text) and functions. Its a kicad project zip file, so "kicad_*.zip" can be the file type

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 30.11 MB
  • After: 30.15 MB
  • Change: 📈 36.13 KB (0.12%)

Diff

No significant changes in bundle size.

View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 617.30 KB
ms@^2.1.3 530.54 KB
posthog-js@^1.203.2 229.68 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.54 KB
@tscircuit/footprinter@^0.0.96 122.03 KB
circuit-json@^0.0.126 118.90 KB
zod@^3.23.8 117.16 KB
circuit-to-svg@^0.0.99 101.33 KB
tailwind-merge@^2.5.2 69.93 KB
dsn-converter@^0.0.54 32.97 KB
react-helmet@^6.1.0 29.17 KB
fflate@^0.8.2 19.95 KB
states-us@^1.1.1 7.27 KB
use-mouse-matrix-transform@^1.1.13 5.80 KB
zustand@^4.5.5 4.17 KB
file-saver@^2.0.5 3.58 KB
vite@^5.4.8 3.24 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
clsx@^2.1.1 783.00 B
use-async-memo@^1.2.5 759.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
What is this? This is an automated bundle size report generated during the build process.

@Anshgrover23
Copy link
Contributor Author

Anshgrover23 commented Jan 3, 2025

@seveibar can u just clarify you want me to change from this ${fileName}.zip to ${fileName}.kicad_*.zip because i am lil confused ?? or is this ok. now

@Anshgrover23 Anshgrover23 requested a review from seveibar January 3, 2025 17:17
@seveibar
Copy link
Contributor

seveibar commented Jan 3, 2025

@Anshgrover23 the filename should be _kicad.zip, but to hint to the user that it contains different types of kicad files we can have the dropdown display kicad_*.zip

@Anshgrover23
Copy link
Contributor Author

@seveibar done.

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 30.11 MB
  • After: 30.15 MB
  • Change: 📈 36.13 KB (0.12%)

Diff

No significant changes in bundle size.

View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 617.30 KB
ms@^2.1.3 530.54 KB
posthog-js@^1.203.2 229.68 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.54 KB
@tscircuit/footprinter@^0.0.96 122.03 KB
circuit-json@^0.0.126 118.90 KB
zod@^3.23.8 117.16 KB
circuit-to-svg@^0.0.99 101.33 KB
tailwind-merge@^2.5.2 69.93 KB
dsn-converter@^0.0.54 32.97 KB
react-helmet@^6.1.0 29.17 KB
fflate@^0.8.2 19.95 KB
states-us@^1.1.1 7.27 KB
use-mouse-matrix-transform@^1.1.13 5.80 KB
zustand@^4.5.5 4.17 KB
file-saver@^2.0.5 3.58 KB
vite@^5.4.8 3.24 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
clsx@^2.1.1 783.00 B
use-async-memo@^1.2.5 759.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
What is this? This is an automated bundle size report generated during the build process.

@tscircuitbot
Copy link

📊 Bundle Size Analysis

Total Bundle Size

  • Before: 30.11 MB
  • After: 30.15 MB
  • Change: 📈 36.13 KB (0.12%)

Diff

No significant changes in bundle size.

View Dependencies
Package Size
typescript@^5.6.3 8.69 MB
@babel/standalone@^7.26.2 4.82 MB
react@^18.3.1 617.30 KB
ms@^2.1.3 530.54 KB
posthog-js@^1.203.2 229.68 KB
jszip@^3.10.1 139.73 KB
react-dom@^18.3.1 138.54 KB
@tscircuit/footprinter@^0.0.96 122.03 KB
circuit-json@^0.0.126 118.90 KB
zod@^3.23.8 117.16 KB
circuit-to-svg@^0.0.99 101.33 KB
tailwind-merge@^2.5.2 69.93 KB
dsn-converter@^0.0.54 32.97 KB
react-helmet@^6.1.0 29.17 KB
fflate@^0.8.2 19.95 KB
states-us@^1.1.1 7.27 KB
use-mouse-matrix-transform@^1.1.13 5.80 KB
zustand@^4.5.5 4.17 KB
file-saver@^2.0.5 3.58 KB
vite@^5.4.8 3.24 KB
@vercel/analytics@^1.4.1 2.88 KB
redaxios@^0.5.1 1.83 KB
clsx@^2.1.1 783.00 B
use-async-memo@^1.2.5 759.00 B
codemirror@^6.0.1 595.00 B
country-list@^2.3.0 387.00 B
extract-codefence@^0.0.4 151.00 B
jscad-electronics@^0.0.24 63.00 B
What is this? This is an automated bundle size report generated during the build process.

@Anshgrover23 Anshgrover23 requested a review from seveibar January 3, 2025 18:48
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work /tip $3

@seveibar seveibar merged commit 9ba2759 into tscircuit:main Jan 3, 2025
5 of 6 checks passed
Copy link

algora-pbc bot commented Jan 3, 2025

🎉🎈 @Anshgrover23 has been awarded $3! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow downloading of kicad_pcb file in kicad options
3 participants