-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Download JSON button added #26
Conversation
@DhairyaMajmudar is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
can we remove this button? as per the discussion here: #16 (comment) You could easily adapt this PR to make the Download Circuit JSON button though! |
I got you let me modify this PR for downloading JSON data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the download button is clicked, compute the url and direct the user to download. Recomputing and rerunning typescript is too expensive
you can probably pass in the circuit json from the parent as a prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments, we don't want to run the tsx (expensive operation) every time the download button renders
Co-authored-by: Severin Ibarluzea <seve700@gmail.com>
This was completed in #49 |
-> Download JSON button is now functional
-> cloese #17
-> related to #16
cc: @seveibar