-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: search text #182
Conversation
@rohittcodes is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm requiring playwright tests for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! but the snapshot is out of date
@seveibar updated the snapshots! |
@rohittcodes sorry i wrote that comment super quickly and didn't explain, see how "snippets" is in the header? If you merge with main we no longer have "snippets" in the header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to give a pass on the snapshot issue for now because other snapshots have the same issue and it doesn't seem to impact the testing too dramatically
playwright tests are facing errors with the initial xs and md devices since they're hidden. will be pushing them after feedbacks (if necessary)
playwright-test for lg-devices:![search spec ts-Search-Input-lg](https://private-user-images.githubusercontent.com/104308198/384756082-f8ac5ccc-3e96-47b4-aaff-2a0b5c42d56f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyOTA2NjUsIm5iZiI6MTczOTI5MDM2NSwicGF0aCI6Ii8xMDQzMDgxOTgvMzg0NzU2MDgyLWY4YWM1Y2NjLTNlOTYtNDdiNC1hYWZmLTJhMGI1YzQyZDU2Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNjEyNDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NjQ4MDkwNTlhOWIzZjdiZTdlNDhjZDBkOTNmNWRmNjhjMTY3NDA4NWVlYmYxZjZjNTM4ZGNkODNhMWY5MjcyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.A9_dZyuG6BFxxCeO8ZthL-Dk_AM-IxFmpBGw-CLsx54)
before:
after-fix:![search spec ts-Search-Input-lg-1 (2)](https://private-user-images.githubusercontent.com/104308198/384756075-213d6ee9-e95e-4896-83d9-115941cf5712.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyOTA2NjUsIm5iZiI6MTczOTI5MDM2NSwicGF0aCI6Ii8xMDQzMDgxOTgvMzg0NzU2MDc1LTIxM2Q2ZWU5LWU5NWUtNDg5Ni04M2Q5LTExNTk0MWNmNTcxMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNjEyNDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MzdiMjY2OTIyMDZhYzE0MzhhNWZkYWQ2NDlhNmE4NTBkNTU3NzcyNjI4MmI1ZjA5OWFlMjBmNTZlNjM0NGZkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9._ol1PQ7qfghbbqXJ9rk-40EPIVQMWxw4y35VB5Ug5qY)
/claim #79
fixes: #79