Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: search text #182

Merged
merged 6 commits into from
Nov 13, 2024
Merged

refactor: search text #182

merged 6 commits into from
Nov 13, 2024

Conversation

rohittcodes
Copy link
Contributor

playwright tests are facing errors with the initial xs and md devices since they're hidden. will be pushing them after feedbacks (if necessary)

playwright-test for lg-devices:
before: search spec ts-Search-Input-lg

after-fix: search spec ts-Search-Input-lg-1 (2)

/claim #79
fixes: #79

Copy link

vercel bot commented Nov 11, 2024

@rohittcodes is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm requiring playwright tests for this one

@rohittcodes rohittcodes requested a review from seveibar November 13, 2024 06:30
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! but the snapshot is out of date

@rohittcodes
Copy link
Contributor Author

@seveibar updated the snapshots!

@seveibar
Copy link
Contributor

@rohittcodes sorry i wrote that comment super quickly and didn't explain, see how "snippets" is in the header? If you merge with main we no longer have "snippets" in the header

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to give a pass on the snapshot issue for now because other snapshots have the same issue and it doesn't seem to impact the testing too dramatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce size of search text
2 participants