Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Command palette search #121

Merged
merged 13 commits into from
Oct 31, 2024
Merged

Conversation

mrudulpatil18
Copy link
Contributor

@mrudulpatil18 mrudulpatil18 commented Oct 23, 2024

Fixes #119

Changes:

  • Rewrote a bunch of logic to fix the search filtering issue
  • Now uses Fuzzy search to filter possible commands in the CMD-K menu
  • This fixes the searching results not shown issue

cc: @seveibar

Copy link

vercel bot commented Oct 23, 2024

@mrudulpatil18 is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

@mrudulpatil18
Copy link
Contributor Author

NOTE: still requires a bit of work with a weird bud and some refactoring, will do when i get some free time

@mrudulpatil18
Copy link
Contributor Author

@seveibar

i found that utlizing ui components from command.tsx was causing the bug in searching
I rewrote to use cmd-k library directly to display the cmdk resutls
So the bug is now fixed

As of now CMD-K bar shows:

  • recent snippets ( if no search query )
  • search results ( title contains search query )
  • all the options of creating new snippets / from templates etc from quickstart page

note: UI look of cmd k bar is different now, will have to style it better

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Yea i prefer the cmdk library so i support the change

@seveibar
Copy link
Contributor

@mrudulpatil18 can we merge to capture these changes?

@mrudulpatil18
Copy link
Contributor Author

@mrudulpatil18 can we merge to capture these changes?

Yup, it's working as of now

@mrudulpatil18
Copy link
Contributor Author

@seveibar
added absolute position for the cmd-k dialog

@seveibar seveibar merged commit 150dddd into tscircuit:main Oct 31, 2024
3 of 5 checks passed
@mrudulpatil18 mrudulpatil18 deleted the command-palette branch November 16, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CmdK Menu Doesn't Search Snippets Properly (no results when searching)
2 participants