Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apps): fill incubator with a bunch of new apps #1083

Merged
merged 16 commits into from
Oct 13, 2021
Merged

feat(apps): fill incubator with a bunch of new apps #1083

merged 16 commits into from
Oct 13, 2021

Conversation

PrivatePuffin
Copy link
Member

@PrivatePuffin PrivatePuffin commented Oct 2, 2021 •
edited
Loading

Description
This PR adds a lot of Apps. 'Nuf said.

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@PrivatePuffin PrivatePuffin added the enhancement New feature or request label Oct 2, 2021
@stavros-k
Copy link
Collaborator

Removed

  • formalms - needs DB
  • leantime - needs DB
  • xbackbone - needs DB

Didn't remove

  • blog - builtin sqlite - But can use mariadb
  • chyrp-lite - builtin sqlite - But can use mysql

@stavros-k
Copy link
Collaborator

While some s6 apps pass test, running as root but with readonlyrootfs enabled.
There are still errors in their logs complaining about it, Apps seem to start and die after a while.
(That's why I disabled readonlyrootfs on e241f7b)

@stavros-k
Copy link
Collaborator

stavros-k commented Oct 3, 2021 •
edited
Loading

Removed this because depends on external DB

  • bookstack
    Also booksonic (it's logs says to migrate to booksonic-air which we already have)

@stavros-k
Copy link
Collaborator

stavros-k commented Oct 3, 2021 •
edited
Loading

"todo" app spits an error, found 'related' issue on the image repo, but it's for armv7

@stavros-k
Copy link
Collaborator

All s6 apps should be ready.
Only valheim an error (while passing test) but not sure if it makes app unsuable or not.

@PrivatePuffin
Copy link
Member Author

@stavros-k Could you please also indicate WHICH DB is needed?
Because now I cannot document them into the catagories I made.

@stavros-k
Copy link
Collaborator

@stavros-k Could you please also indicate WHICH DB is needed? Because now I cannot document them into the catagories I made.

  • formalms - MySQL / MariaDB
  • leantime - MySQL
  • xbackbone - MySQL
  • bookstack - MariaDB
  • blog (sqlite builtin) - MariaDB
  • chyrp-ltie (sqlite builtin) - MySQL

@PrivatePuffin PrivatePuffin force-pushed the WIP branch 7 times, most recently from e5a4bd4 to 7f7daa4 Compare October 4, 2021 16:32
@stavros-k
Copy link
Collaborator

stavros-k commented Oct 8, 2021 •
edited
Loading

Notes

Didn't port anything under secret: for any app

  • Aria2
    • Didn't port /downloads as persistence
    • Didn't port listen service's ingress
  • Beets
    • Didn't port /music and /downloads as persistence
  • Cloud9
    • Didn't port docker sock
  • Davos
    • Didn't port /download as persistence
  • Doublecommander
    • Didn't port /data as persistence
  • Headphones
    • Didn't port /music and /downloads as persistence
  • Medusa
    • Didn't port /tv and /downloads as persistence
  • Mstream
    • Didn't port /music as persistence
  • Photoshow
    • Didn't port /Pictures and /Thumbs as persistence
  • Piwigo
    • Didn't port /gallery as persistence
  • Pixapop
    • Didn't port /photos as persistence
  • Sickchill
    • Didn't port /tv and /downloads as persistence
    • it's values.yaml could use some cleanup on the persistence section (maybe?)
  • Sickgear
    • Didn't port /tv and /downloads as persistence

Skipped for now

  • amcrest2Mqtt
  • cryptfolio
  • icantbelieveitsnotvaletudo
  • leaf2mqtt
  • minio-console
  • valheim
  • whoogle
  • zigbee2mqtt

After syncing all apps, change strategy to RollingUpdate on apps without persistence

EDIT: I'll work on skipped apps tomorrow, as my battery is low and no plug available in the ship 🚢 :/

@PrivatePuffin
Copy link
Member Author

PrivatePuffin commented Oct 9, 2021 •
edited
Loading

@stavros-k Sadly enough destroyed the changes by accident, please push again :(

The Didn't port list looks great though 👍
In the mean time I adapted the questions.yaml a bit to the new ingress and serviceExpert includes (which should safe a few thousant rows of code in this PR)

@PrivatePuffin
Copy link
Member Author

@stavros-k Another note:
The "Secrets" section, is just another way to handle env-vars (they get stored in a secret and then loaded as env-vars).

@PrivatePuffin PrivatePuffin force-pushed the WIP branch 2 times, most recently from 836b530 to a0fd0c7 Compare October 10, 2021 14:06
@stavros-k
Copy link
Collaborator

Did I just created this onlyoffice conflicts again?! How?!

@PrivatePuffin
Copy link
Member Author

Did I just created this onlyoffice conflicts again?! How?!

Nope I did, by updating onlyoffice as it's patch tuesday, please ignore.

@PrivatePuffin
Copy link
Member Author

@stavros-k Rebased and fixed.

kjeld Schouten-Lebbing and others added 9 commits October 13, 2021 16:09
(feat) fill incubator with a bunch of new apps
7192d68
Ornias' cleanup
6140c17
@stavros-k
stavros' cleanup
0919284
Ornias' second cleanup
c7aa431
Add basic SCALE Compatibility layer and docs
0094432
Ornias's cleanup 3
0563870
@stavros-k
Stavros' cleanup 2
a2e8545 
Update service's port on the skipped apps (+32 squashed commit)

Squashed commit:

[361963c] config -> data on some apps

[545c32b] wiki

[41fb4f5] twtxt

[02169ba] static

[a904266] sqlitebrowser

[f09ce3d] smokeping

[01d2f9a] sickgear

[680fd35] sickchill

[7185648] shorturl

[ce130ac] Remmina

[6410ec2] pixapop

[a1ea2a3] Piwigo

[0b4c52d] photoshow

[25e9a44] novnc

[84954de] notes

[b3be0b2] muximux

[43d2b37] mstream

[736f987] Medusa

[8ef3434] Headphones

[05e5228] Grav

[7ce6f17] golinks

[b4eee91] fossil

[d19b444] FIlezilla

[9262364] Doublecommander

[6f68e52] Digikam

[f14d3af] Davos

[8108c01] Code-server

[4969917] Cloud9

[4ad02a9] Beets

[f2f0565] Apache-musicindex

[9bf8de8] aria2

[283edf7] Audacity
Ornias' cleanup 4
b7eada0 
try something for amcrest and zigbee (+8 squashed commit)

Squashed commit:

[a199779a9] First part of  leaf2mqtt

[0eb7fea43] cryptfolio

[81c2b9b8b] amcrest readonly default true

[fc62aebb4] setup amcrest2mqtt

[d97f7d1fe] remove empty secret references

[ec0e6b1b3] remove sogo for now (till we have a decent mail server and such)

[9be04c1e7] Adapt to recent serviceExpert changes (includes)

(cherry picked from commit 98acc5f)

[8362ebc89] Adapt to recent ingress changes in questions.yaml (includes)

(cherry picked from commit d307ba9)
@stavros-k
Stavros' cleanup 3
e857809 
leaf2mqtt actually needs root when the core fuctionality env's are populated (+6 squashed commit)

Squashed commit:

[4ef306f] minio-console

[6ad206b] finish whoogle and move fixed envs on top

[aaf4857] finish 4 apps

[97ad3fd] don't leave sercrets empty

[e27b988] sync more env's and sercrets

[3989290] sync secrets
@PrivatePuffin PrivatePuffin changed the title (feat) fill incubator with a bunch of new apps feat(apps): fill incubator with a bunch of new apps Oct 13, 2021
@PrivatePuffin
Copy link
Member Author

TODO:

  • move stateless app to rolling.
  • final checkup

@PrivatePuffin PrivatePuffin marked this pull request as ready for review October 13, 2021 19:54
@PrivatePuffin
Copy link
Member Author

Merging, as I expect the VAST majority of apps to either be working or require just minor touchups. Which are easier to do in a seperate PR.

@PrivatePuffin PrivatePuffin merged commit a26eb7e into master Oct 13, 2021
@PrivatePuffin PrivatePuffin deleted the WIP branch October 21, 2021 19:56
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@PrivatePuffin PrivatePuffin

@stavros-k stavros-k

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrivatePuffin @stavros-k @truecharts-admin