Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed API calls to both authentication login from Burp API #19

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ganesh2183
Copy link

Added api call to recorded login script feature.

username=username, password=password,
exclude_rules=exclude_rules, scan_configurations=scan_configurations)

if label and script:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if label and script:
elif label and script:

Copy link
Owner

@tristanlatr tristanlatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're close to make it work, don't give up :)

app_user=app_user,
app_pass=app_pass,
recorded_login_label=recorded_login_label,
recorded_login_script=recorded_login_script,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to read the recorded_login_script file before passing it to the _start_scan function.
To read a file one can use the open function.

@ganesh2183
Copy link
Author

ganesh2183 commented Dec 8, 2022

Added API calls to recorded login script authentication login method, it works as expected.

Updated code changes in utils.py, burpa.py and burp_commander.py files.

Could you please verify from your end and confirm on this.

burpa scan https://example.com/login --recorded_login_label=Login --recorded_login_script="Login.json"

@ganesh2183
Copy link
Author

Added API calls to recorded login script authentication login method, it works as expected.

Updated code changes in utils.py, burpa.py and burp_commander.py files.

Could you please verify from your end and confirm on this.

burpa scan https://example.com/login --recorded_login_label=Login --recorded_login_script="Login.json"

Please check this and confirm.

@tristanlatr
Copy link
Owner

Have you tried it on your end ?
Because it seems that it's not even compiling.

@ganesh2183
Copy link
Author

Have you tried it on your end ? Because it seems that it's not even compiling.
I checked it is working for me.

@tristanlatr
Copy link
Owner

I checked it is working for me.

It cannot possibly be true, there is a syntax error :/

@ganesh2183
Copy link
Author

I checked it is working for me.

It cannot possibly be true, there is a syntax error :/

What syntax error you are getting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants