-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed API calls to both authentication login from Burp API #19
base: main
Are you sure you want to change the base?
Conversation
Replaced code changes for application_login api call 'UsernameAndPasswordLogin' with 'RecordedLogin'.
Update _burp_commander.py
Update _burp_commander.py
burpa/_burp_commander.py
Outdated
username=username, password=password, | ||
exclude_rules=exclude_rules, scan_configurations=scan_configurations) | ||
|
||
if label and script: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if label and script: | |
elif label and script: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're close to make it work, don't give up :)
app_user=app_user, | ||
app_pass=app_pass, | ||
recorded_login_label=recorded_login_label, | ||
recorded_login_script=recorded_login_script, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to read the recorded_login_script
file before passing it to the _start_scan
function.
To read a file one can use the open
function.
Added API calls to recorded login script authentication login method, it works as expected. Updated code changes in utils.py, burpa.py and burp_commander.py files. Could you please verify from your end and confirm on this. burpa scan https://example.com/login --recorded_login_label=Login --recorded_login_script="Login.json" |
Please check this and confirm. |
Have you tried it on your end ? |
|
It cannot possibly be true, there is a syntax error :/ |
What syntax error you are getting? |
Added api call to recorded login script feature.