Fixed regression where testRepository would erroneously pass with i…

…nvalid credentials. Fixed Exception thrown with `bin/plugin git-sync status` command, preventing `sync` (#199, fixes #200)
trilbymedia · Apr 30, 2021 · 7f7b127 · 7f7b127
1 parent c9a3d33
commit 7f7b127
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+# v2.3.1
+## 04/30/2021
+
+1. [](#bugfix)
+   * Fixed regression where `testRepository` would erroneously pass with invalid credentials [#200](https://github.com/trilbymedia/grav-plugin-git-sync/issues/200)
+   * Fixed Exception thrown with `bin/plugin git-sync status` command, preventing `sync` [#200](https://github.com/trilbymedia/grav-plugin-git-sync/issues/200)
+
 # v2.3.0
 ## 04/27/2021
 

diff --git a/classes/GitSync.php b/classes/GitSync.php
@@ -481,7 +481,7 @@ public function execute($command, $quiet = false)
                 exec($command, $output, $returnValue);
             }
 
-            if ($returnValue !== 0 && (!empty($output) && $returnValue === 5) && !$quiet) {
+            if ($returnValue !== 0 && $returnValue !== 5 && !$quiet) {
                 throw new \RuntimeException(implode("\r\n", $output));
             }
 

diff --git a/cli/StatusCommand.php b/cli/StatusCommand.php
@@ -90,7 +90,8 @@ protected function serve()
             Helper::prepareRepository(
               $plugin->getUser() ?? '',
               $password,
-              $repository)
+              $repository),
+            $plugin->getRemote('branch', null),
         );
         $this->console_log($testRepository, $password);