npm-release: @trezor/connect 9.5.0 #17208
Conversation
|
trezor-ci
requested review from
mroz22,
marekrjpolak,
martykan,
szymonlesisz,
karliatto and
tomasklim
as code owners
|
karliatto
added
the
no-project
WalkthroughThe pull request updates multiple packages by transitioning their version numbers from beta releases to stable versions. In many cases, the package.json files and corresponding CHANGELOG.md entries have been revised to reflect this change—examples include updates to versions such as 1.3.0, 2.4.0, 9.5.0, 1.1.0, and 2.3.0. Several packages have also received new entries in their changelogs to document added features, bug fixes, and improvements, such as enhanced support for Solana staking, modifications to transaction parsing and error handling, and updates to utility functions and interface definitions. Additionally, there are code quality improvements like autofixing ESLint rules. The changes uniformly remove or replace npm prerelease version tags with their stable counterparts while maintaining the overall changelog structure and package metadata. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (14)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/utils/CHANGELOG.md (1)
1-21: Changelog Cleanup and Clarification
The changelog entry for version 9.3.0 removes beta-specific entries, which aligns with the stable release. To further improve clarity for end users, consider adding a brief bullet-point summary of the key changes—such as the removal ofcreateTimeoutPromise, the addition ofserializeError, the introduction ofisWhitelistedHost, and the caching mechanism with TTL. This will help readers quickly understand the major improvements in this release.packages/connect-common/CHANGELOG.md (2)
6-6: Typo in Commit Message:
There is a typo in the commit message: “uptate coins.json…” should be corrected to “update coins.json…” for clarity and consistency.
16-16: Typo in Package Name:
There is a minor typo in “chore(connect-commmon): …” on line 16. The package name should be “connect-common” (with a single “m”) to maintain consistency.packages/utxo-lib/CHANGELOG.md (2)
17-30: Cleanup and Stable Update for 2.2.2
A large block of entries has been removed—from the npm prerelease tag to several chore and feature notes. This helps transition the changelog from verbose internal/development notes to a cleaner, user-facing release history.
Note: There are several typographical issues in the removed content (e.g. “recommanded” should be “recommended”, “conllision” should be “collision”, “algorithymns” should be “algorithms”, “reandom” should be “random”, and “skipPermitationparam” may need correction). Please confirm that the final changelog (or corresponding documentation) is free of these errors.
94-127: Breaking Changes Documentation for 2.0.1
This section removes a long list of detailed commit notes under a "BREAKING CHANGES" header for thecomposeTxmodule. While it’s good to signal breaking changes, consider summarizing the most impactful changes in a more concise upgrade note to help developers navigate the breaking changes.🧰 Tools
🪛 LanguageTool
[uncategorized] ~96-~96: You might be missing the article “the” here.
Context: ...3de3e3a8) # 2.0.1 BREAKING CHANGES incomposeTxmodule. renamedcomposeTxr...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (35)
packages/analytics/CHANGELOG.md(1 hunks)packages/analytics/package.json(1 hunks)packages/blockchain-link-types/CHANGELOG.md(1 hunks)packages/blockchain-link-types/package.json(1 hunks)packages/blockchain-link-utils/CHANGELOG.md(1 hunks)packages/blockchain-link-utils/package.json(1 hunks)packages/blockchain-link/CHANGELOG.md(1 hunks)packages/blockchain-link/package.json(1 hunks)packages/connect-analytics/CHANGELOG.md(1 hunks)packages/connect-analytics/package.json(1 hunks)packages/connect-common/CHANGELOG.md(1 hunks)packages/connect-common/package.json(1 hunks)packages/connect-web/package.json(1 hunks)packages/connect-web/src/webextension/trezor-usb-permissions.js(1 hunks)packages/connect-webextension/package.json(1 hunks)packages/connect/CHANGELOG.md(1 hunks)packages/connect/README.md(1 hunks)packages/connect/package.json(1 hunks)packages/connect/src/data/version.ts(1 hunks)packages/crypto-utils/CHANGELOG.md(1 hunks)packages/crypto-utils/package.json(1 hunks)packages/env-utils/CHANGELOG.md(1 hunks)packages/env-utils/package.json(1 hunks)packages/protobuf/CHANGELOG.md(1 hunks)packages/protobuf/package.json(1 hunks)packages/schema-utils/CHANGELOG.md(1 hunks)packages/schema-utils/package.json(1 hunks)packages/transport/CHANGELOG.md(1 hunks)packages/transport/package.json(1 hunks)packages/utils/CHANGELOG.md(1 hunks)packages/utils/package.json(1 hunks)packages/utxo-lib/CHANGELOG.md(1 hunks)packages/utxo-lib/package.json(1 hunks)packages/websocket-client/CHANGELOG.md(1 hunks)packages/websocket-client/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (20)
- packages/connect-common/package.json
- packages/schema-utils/package.json
- packages/env-utils/package.json
- packages/connect/package.json
- packages/blockchain-link-utils/package.json
- packages/connect/README.md
- packages/connect-webextension/package.json
- packages/connect-web/package.json
- packages/analytics/package.json
- packages/blockchain-link-types/package.json
- packages/websocket-client/CHANGELOG.md
- packages/websocket-client/package.json
- packages/blockchain-link/package.json
- packages/connect-analytics/package.json
- packages/connect-web/src/webextension/trezor-usb-permissions.js
- packages/crypto-utils/package.json
- packages/protobuf/package.json
- packages/utxo-lib/package.json
- packages/connect/CHANGELOG.md
- packages/crypto-utils/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: PR-check / node-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
- GitHub Check: PR-check / node-override init-api-flaky
- GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
- GitHub Check: PR-check / web-override init-api-flaky
- GitHub Check: build-deploy
- GitHub Check: build-deploy
- GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=passphrase, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
- GitHub Check: transport-e2e-test
- GitHub Check: test
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: build-web
- GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: prepare_android_test_app
- GitHub Check: build-web
- GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (45)
packages/connect/src/data/version.ts (1)
1-1: Version updated from beta to stable release.The VERSION constant has been updated from '9.5.0-beta.1' to '9.5.0', correctly transitioning from a beta release to a stable release. This change will impact the
isBetaconstant (nowfalse) and consequently theDEFAULT_DOMAINvalue, which will now behttps://connect.trezor.io/9/instead of the beta-specific URL.packages/utils/package.json (1)
3-3: Stable Version Update
The version change to"9.3.0"correctly transitions the package from a beta to a stable release. Please ensure that all related documentation and dependency references reflect this updated version.packages/connect-common/CHANGELOG.md (5)
1-2: Version Header Update:
The version header is updated to “0.3.0”, which correctly reflects the stable release transition as intended by the PR objectives.
3-5: Removal of Outdated Beta Entries:
The entries for pre-releases (0.3.0-beta.1and0.2.8-beta.1) are removed, aligning the changelog with the move from beta to stable. Please confirm that no additional references to beta versions remain in related documentation.
7-9: Coin Configuration Updates:
The changes for autofixing the sort-imports ESLint rule, updating coins and coins-eth for T3W1 support, and sorting coins-eth.json bychain_idare clear and beneficial for maintainability.
10-12: TransportInfo and Firmware Binaries Adjustments:
The simplification oftransportInfoalongside the addition of firmware binaries for version 2.8.7 and the update of network proxies are well-documented enhancements. Ensure that these changes are consistently reflected in any dependent configurations.
13-15: Feature Enhancements Documentation:
The changelog now includes important feature updates such as the BNB to BSC migration, the addition of L2 ETH networks support, and the introduction of Arbitrum One. These entries are clearly noted—please double-check that all related improvements are thoroughly reflected in the release notes and documentation.packages/utxo-lib/CHANGELOG.md (20)
3-10: Stable Release Update for 2.3.0
The prerelease entries (e.g. "2.3.0-beta.1" and related internal notes) have been removed, which is consistent with moving to a stable release.
13-13: Removal of Prerelease Tag for 2.2.3
The removal of the "npm-prerelease: @trezor/utxo-lib 2.2.3-beta.1" entry indicates that this version is now intended as a stable release.
34-38: Stable Update for 2.2.1
The removal of the prerelease entry and minor dependency update notes cleans up the changelog for version 2.2.1. Ensure that all changes impacting end users are captured elsewhere if needed.
41-43: Stable Release Correction for 2.2.0
Removing the "2.1.1-beta.1" entry along with the tx update note aligns with this version’s final release. Verify that the production changelog now reflects only the stable changes.
46-47: Update for 2.0.11-beta.1 Transition
The removal of the note about “removing create-hash dependency” is appropriate in the context of finalizing the version.
50-51: Refinement for 2.0.9
The deleted entry on supporting checksums in descriptor parsing seems intended for internal tracking. Please ensure that any end-user–relevant behavior is documented in the official release notes if applicable.
54-58: Changelog Cleanup for 2.0.8
Several internal updates (lint fixes, CI/test improvements, TypeScript project reference changes, etc.) have been removed. This simplifies the changelog to highlight functionality changes for users rather than internal improvements.
61-73: Cleanup for 2.0.7
A broad set of chore updates and dependency revisions has been removed. It’s advisable to confirm that the changelog now only exposes relevant, user-impacting changes while internal updates are documented elsewhere.
76-77: Note on 2.0.4
The entry regarding the replacement ofglobal.d.tswithglobal.tshas been removed. If this migration impacts users (or requires migration steps), ensure that appropriate documentation is provided separately.
80-82: Simplification for 2.0.3
Removing the refactoring note about using the spread operator instead ofObject.assignis acceptable as it likely reflects an internal code improvement.
85-93: Consolidation for 2.0.2
Multiple detailed entries related tocomposeTxand coin selection refactoring have been removed. Ensure that major user-impacting changes remain highlighted in the overall release notes, while these granular internal updates can be maintained in internal docs.
128-138: Cleanup for 1.0.11
The removal of entries related to tests, fee policies, and refactoring helps keep the changelog user-centric. Just ensure that significant feature changes remain clearly visible where they impact functionality.
139-150: Changelog Refinement for 1.0.10
The removal of various entries related to coin selection algorithms, fixture adjustments, and utility renames aligns with streamlining the changelog. Verify that the end-user documentation still reflects any changes that affect behavior.
151-154: Note on 1.0.8
The entry for supporting Litecoin address derivation has been removed. Please verify whether this change represents a deprecation of the feature or if it is documented elsewhere, as it might be significant to users.
155-158: Minor Workspace Update in 1.0.6
The removal of the workspace update note is a minor cleanup and does not affect the end-user experience.
165-168: Changelog Update for 1.0.4
The removed entries regarding Litecoin deserialization improvements and new transaction utility additions should be cross-checked to ensure that any relevant feature changes are communicated in the final release notes.
169-172: Simplification for 1.0.3
Removing the "unused skipUtxoSelection" entry reduces clutter. This is a straightforward cleanup.
173-177: Update for 1.0.2
The deletion of detailed fixes (such as output sorting for huge amounts and support for mweb pegout outputs) streamlines the changelog. Confirm that any critical behavioral fixes are mentioned in the public release notes if they affect users.
178-184: Feature Removal in 1.0.1
Entries for adding features such asTransactionBase.getWitness, Zcash NU5 support, SLIP25 address derivation, and decimal fee rates have been removed. Please verify that this does not inadvertently hide important feature introductions that users might expect to see documented.
185-186: Version 1.0.0
There are no changes in this final version header.packages/transport/package.json (1)
3-3: Version Update: Transition from Beta to Stable Release.
The version has been updated from a beta version (implicitly "1.4.0-beta.1") to the stable release "1.4.0", which is consistent with the npm-release objectives.packages/analytics/CHANGELOG.md (1)
1-6: Changelog Cleanup for Stable Release 1.3.0.
The beta prerelease lines (lines 3–5) have been removed so that the changelog now clearly reflects the stable release. This cleanup ensures greater clarity in the version history.packages/env-utils/CHANGELOG.md (1)
1-6: Changelog Update: Removal of Beta Prerelease Entries for 1.3.0.
Removing the beta prerelease entries (lines 3–5) aligns with the goal of shifting to a stable release version. Ensure that any cross-references in documentation or dependency notes reflect this stable release update.packages/schema-utils/CHANGELOG.md (1)
1-6: Stable Release 1.3.0 Changelog Revision.
The removal of the npm-prerelease entries (lines 3–5) for the beta version is appropriate as we move to a stable release. The changes make the changelog more concise and accurate.packages/connect-analytics/CHANGELOG.md (1)
1-5: Changelog Update for @trezor/connect-analytics Stable Release 1.3.0.
By removing the beta prerelease entry (line 3) and the fix note (line 4) from the 1.3.0 section, the changelog now properly reflects the stable release details. Verify that the fix details are documented elsewhere if they still need to be highlighted.packages/blockchain-link-utils/CHANGELOG.md (3)
1-22: Version 1.3.0 Changelog Entry – Verify Stable Label
The 1.3.0 release notes list important new features (Solana v2 staking support, SDK upgrades, addition of stakingAccounts, etc.). However, the log still shows
npm-prerelease: @trezor/blockchain-link-utils 1.3.0-beta.1
which suggests a beta release. Please confirm whether this line should be updated (i.e. remove the “-beta.1” tag) for a stable release version.
23-42: Historical Version Blocks – Consistency Check
The subsequent version blocks (1.2.x, 1.1.x, …) are detailed and well documented. Please double-check that the beta labels in these historical entries are in line with your release policies (i.e. should they be preserved as historical records or updated for a stable release history?).
43-168: Overall Changelog Consistency
The changelog is very comprehensive and includes commit hashes and descriptive tags (feat, fix, chore). Ensure that this document is synchronized with any updates in dependent packages so that release notes remain consistent across the ecosystem.packages/protobuf/CHANGELOG.md (2)
1-12: 1.3.0 Entry – Beta Tag Review for Protobuf
The 1.3.0 section covers updates such as protobuf definitions changes and the new added key (ResetDevice.entropy_check). However, the entry
npm-prerelease: @trezor/protobuf 1.3.0-beta.1
appears in the release block. Please verify if the beta tag should be removed before the final stable release.
13-44: Historical Versions and Legacy Entries
The remaining entries (from 1.2.6 and below) are solid and serve as a proper historical record. Ensure again that any beta markings align with your versioning strategy across all releases.🧰 Tools
🪛 LanguageTool
[grammar] ~30-~30: The modal verb ‘will’ requires the verb’s base form.
Context: ...a2d) - chore: add no-empty as it will became part of recommanded (ef2dd42) - fe...(MD_BASEFORM)
packages/blockchain-link/CHANGELOG.md (2)
1-9: Version 2.4.0 Update – Beta Label Verification
The changelog for 2.4.0 clearly documents added support for Solana v2 staking, the inclusion of BTC testnet4 in the UI, and the switch to use@trezor/websocket-client. Notice that the log includes
npm-prerelease: @trezor/blockchain-link 2.4.0-beta.1
as one of the entries. Please check that the beta label is updated to reflect a stable release if that is your intention.
10-39: Legacy Entries – Overall Versioning Consistency
Entries for versions 2.3.x and below are detailed and feel consistent. Please ensure that these historical notes remain unchanged unless there is an intentional update to them.🧰 Tools
🪛 LanguageTool
[uncategorized] ~38-~38: The official spelling of this programming framework is “Node.js”.
Context: ...r setTimeout return type to address the NodeJS types leak issue (3f34981) - fix(b...(NODE_JS)
packages/transport/CHANGELOG.md (3)
1-27: Transport Package 1.4.0 Changelog Review
For version 1.4.0, the release notes detail several key improvements such as dependency updates, fixes in USB device handling and abortable tasks, and a newpingfeature as well as thesetTransportsmethod. One item in particular shows:
npm-prerelease: @trezor/transport 1.4.0-beta.1
Please verify if the beta tag is still applicable here or if it should be replaced with the stable version number as part of the final release.
28-37: Subsequent Changes and Detail Orientation
The next set of entries (covering versions 1.3.x and lower) are well detailed. Their documentation of improvements—ranging from log-verbosity reductions to refactoring and dependency bumps—is clear.🧰 Tools
🪛 LanguageTool
[uncategorized] ~31-~31: The official spelling of this programming framework is “Node.js”.
Context: ...r setTimeout return type to address the NodeJS types leak issue (3f34981) - chore...(NODE_JS)
38-342: Overall Transport Changelog – Comprehensive Documentation
This changelog is very exhaustive and captures granular improvements and fixes that have been applied over many versions. Please double-check that any beta references are corrected when these changes are “released” in a stable version. The detailed commit hashes and explicit descriptions will be very useful to track regressions or troubleshoot issues later on.🧰 Tools
🪛 LanguageTool
[grammar] ~52-~52: The preposition ‘to’ may be missing (allow someone to do something).
Context: ...dge): synchronize was too strict, allow enumerate and call (b7afbd0) - fix(connect):...(ALLOW_TO_DO)
[grammar] ~55-~55: The modal verb ‘will’ requires the verb’s base form.
Context: ...e7b) - chore: add no-empty as it will became part of recommanded (ef2dd42) - ch...(MD_BASEFORM)
[grammar] ~139-~139: The word “timeout” is a noun. The verb is spelled with a space.
Context: ...(1c93308) - fix(transport): do not timeout AbstractApiTransportsendand `receiv...(NOUN_VERB_CONFUSION)
[uncategorized] ~174-~174: The adjective or adverb “drop-dead” is normally spelled with a hyphen.
Context: ...ding (2f445ba) - chore(transport): drop dead code (faba718) - chore(protocol): ...(DROP_DEAD_HYPHEN)
[style] ~186-~186: The adverb ‘also’ is commonly used to connect clauses and isn’t usually used at the end of a phrase or before a conjunction. Consider replacing it with a more formal alternative.
Context: ...5030) - fix(transport): accept logger also for usb transports (3a5dee1) - cho...(ALSO_AS_WELL)
🪛 markdownlint-cli2 (0.17.2)
328-328: Bare URL used
null(MD034, no-bare-urls)
packages/blockchain-link-types/CHANGELOG.md (3)
1-23: Blockchain-Link-Types 1.3.0 Entry – Version Tag Consistency
The 1.3.0 block lists a number of updates such as adding support for Solana v2 staking, expanding the TokenInfo type for NFTs, and introducing the stakingAccounts property. However, the entry
npm-prerelease: @trezor/blockchain-link-types 1.3.0-beta.1
still uses a beta tag. Please confirm whether this should be updated to the stable version for the final release.
24-32: Review of Subsequent (Historical) Entries
The sections for version 1.2.x and earlier continue to provide clear descriptions of dependency updates, removed unused types, and other chore notes. Verify that these remain in line with your documentation policies.
33-168: Overall Changelog Assessment for Blockchain-Link-Types
The changelog is highly detailed and covers all necessary revisions. The inclusion of commit hashes and clear tags (feat, chore, fix) makes it easy to follow the evolution of this package.
|
This change in chagenlog should not be controversial https://github.com/trezor/trezor-suite/pull/17208/files#diff-1fd09e280fc0d5d82363b3fd147de953b7269d6245b63c71bfcc1e896be7a7bf @mroz22 @Hannsek |
@trezor/connect bump version
This is an automatically created PR.
yarn workspace @trezor/connect version:<beta|patch|minor|major>yarn tsx check-npm-dependencies.ts <package_name> <semver>. Please note that this script will report unreleased dependencies even for changes that do not affect runtime (READMEs etc.)