Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eckhart receive flow #4736

Merged
merged 8 commits into from
Mar 6, 2025
Merged

Eckhart receive flow #4736

merged 8 commits into from
Mar 6, 2025

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Mar 5, 2025

This PR implements and updates all components, flows and UI trait functions to implement address receive flow according to the latest design in Figma

Implementation:

  • new mono-space text styles
  • QrScreen full-screen firmware component
  • address receive flow
  • show danger flow
  • show danger UI trait function
  • new Timeout mode for ActionBar

Updates

  • flow-related warning functions
  • Update danger menu item color
  • Update disabled style for button_default to be used in the ActionBar in Timeout mode

@bieleluk bieleluk added the T3W1 label Mar 5, 2025
@bieleluk bieleluk requested a review from obrusvit March 5, 2025 09:29
@bieleluk bieleluk self-assigned this Mar 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

obrusvit
obrusvit reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments for now.

@bieleluk bieleluk requested a review from obrusvit March 6, 2025 10:57
obrusvit
obrusvit approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Please fix the nit below, squash and merge.
Don't forget to remove the unused entry from order.json

@bieleluk bieleluk force-pushed the bieleluk/eckhart-receive branch from cdbe560 to f19a5fe Compare March 6, 2025 12:09
@bieleluk bieleluk force-pushed the bieleluk/eckhart-receive branch from f19a5fe to 86dcf45 Compare March 6, 2025 12:17
@bieleluk bieleluk merged commit 88da295 into ui-eckhart Mar 6, 2025
43 of 48 checks passed
@bieleluk bieleluk deleted the bieleluk/eckhart-receive branch March 6, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

@prusnak prusnak Awaiting requested review from prusnak prusnak is a code owner

Assignees

@bieleluk bieleluk

Labels
T3W1
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bieleluk @obrusvit