Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Nordic Connect SDK to 2.9.0 #4731

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

hiviah
Copy link
Contributor

@hiviah hiviah commented Mar 4, 2025

Bump nRF build to latest Nordic Connect SDK to 2.9.0. Fixes build/linker errors caused by changes in NCS (BLE controller settings).

@hiviah hiviah requested a review from TychoVrahe March 4, 2025 13:24
@hiviah hiviah self-assigned this Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)


```sh
nrfutil toolchain-manager launch --shell
west init -m https://github.com/nrfconnect/sdk-nrf --mr v2.9.0 v2.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don''t think this is needed; we have west init below which will use the west.yml already specifying 2.9.0, so that, along with west update will do the trick

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really unsure about this, it should be as you say, but I had to rebuild fresh many times until pythons from 2 toolchains stopped interfering with each other (it seemed without using this it mixed selected from west.yml with toolchain nrfutil toolchain-manager list listed as default).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i experienced the python mismatch too, for me it helped building with --pristine after the update (and i also uninstalled the older toolchain, but that didn't help). But with this line, we now have west init twice in the readme, which seems wrong to me. I'd say lets remove it now and see what happens

@@ -22,6 +22,7 @@
zephyr,sram = &sram0;
zephyr,flash = &flash0;
zephyr,code-partition = &slot0_partition;
zephyr,bt-hci = &bt_hci_controller;
Copy link
Contributor

@TychoVrahe TychoVrahe Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add these changes to the t3w1_d1_nrf52833 board too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

2 participants