fix(core): use correct fonts for staking confirmation on Delizia #4677
+89
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
romanz
force-pushed
the
romanz/description-font
branch
from
959bc6e to
536e7b9
Compare
romanz
added
the
translations
romanz
force-pushed
the
romanz/description-font
branch
from
536e7b9 to
d6ca581
Compare
romanz
changed the title
ConfirmValue
romanz
changed the title
|
Rebasing to update UI fixtures: |
romanz
force-pushed
the
romanz/description-font
branch
from
d6ca581 to
644f474
Compare
bieleluk
requested changes
Mar 4, 2025
| @@ -527,7 +528,10 @@ impl FirmwareUI for UIDelizia { | |||
| ) -> Result<impl LayoutMaybeTrace, Error> { | |||
| let confirm_main = | |||
| ConfirmValue::new(title.unwrap_or(TString::empty()), message, description) | |||
| .with_description_font(&theme::TEXT_MAIN_GREY_LIGHT) | |||
There was a problem hiding this comment.
I am a bit hesitant about this change.
It is correct according to Figma, but it should have the same color as the address which also has wrong color (GREY_EXTRA_LIGHT instead of GREY_LIGHT).
In the test diff screen, there are now 3 different font colors, which does not look good.
I would either change color of both description and address to GREY_LIGHT or none of them.
There was a problem hiding this comment.
change color of both description and address to
GREY_LIGHT
Sounds good, please take a look at #4733.
There was a problem hiding this comment.
Fixed in #4733, rebasing to resolve UI fixtures' conflicts.
romanz
force-pushed
the
romanz/description-font
branch
from
644f474 to
5dd8418
Compare
bieleluk
approved these changes
Mar 5, 2025
romanz
force-pushed
the
romanz/description-font
branch
from
5dd8418 to
8afb0d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Following #4672.