Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trezorlib fixes #4664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Trezorlib fixes #4664

wants to merge 1 commit into from

Conversation

grdddj
Copy link
Contributor

@grdddj grdddj commented Feb 24, 2025

Trying to solve some new issues with trezorlib I found recently when integrating new emulators into trezor-user-env.

  1. protobuf.py had # type: ignore [Type ["Unknown | None"]], which causes mypy to flag this as a syntax error in any project that uses trezorlib ... example fail in our CI: https://github.com/trezor/trezor-user-env/actions/runs/13370973357/job/37339166006?pr=290
  • I found out that it is fine with other type: ignores, and that the issue disappears when removing the inner [] ... mypy seems to have issues with this
  1. Connected with transport/bridge.py - call_bridge is sending a POST request to bridge URL, but with no timeout. Just last week, with new release emulators, it started happening that the bridge just did not anwer at all. It is strange that it happened just now, with new emulators - we suspect something is different/new in new (2.8.7 and higher) emulators (one other clue is not being able to run Shamir backup flow built for older emulators).

@grdddj grdddj requested a review from matejcik as a code owner February 24, 2025 11:15
Copy link

github-actions bot commented Feb 24, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@grdddj grdddj force-pushed the grdddj/trezorlib_fixes branch from 36de9eb to 0b479b8 Compare February 24, 2025 13:59
@grdddj
Copy link
Contributor Author

grdddj commented Feb 24, 2025

Deleted the timeout-setting code in favor of #4655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

1 participant