lakectl support create repository with sample data #8628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopcoder
added
area/lakectl
|
♻️ PR Preview 9734fab has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
yonipeleg33
approved these changes
Feb 8, 2025
| "STORAGE": storage3, | ||
| "BRANCH": mainBranch, | ||
| } | ||
| RunCmdAndVerifySuccessWithFile(t, Lakectl()+" repo create lakefs://"+repoName3+" "+storage3+" --sample-data", false, "lakectl_repo_create_sample", vars) |
There was a problem hiding this comment.
Nit: There's a command builder for lakectl tests, you can use it.
Here's an example
There was a problem hiding this comment.
- The builder doesn't give any additional value as I see, it doesn't quote args or provide additional functionality above contact. If you still think we should replace all test run of lakectl with the builder style. Lets discuss and address in a different PR.
- Keeping the current usage match the rest of the tests in this function.
- Wish to replace lakectl tests (not in this PR) with something more simple like https://bitfieldconsulting.com/posts/test-scripts. It may not match all the current requirements of the current lakectl_test but I think it will make running it outside esti and modify/add more test easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support create repository with sample data by passing '--sample-data' flag
Closes #8627