change login placeholders for remote authenticator #8519
Conversation
|
♻️ PR Preview 52c5a61 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
guy-har
force-pushed
the
feature/login-placeholders
branch
from
cd05dd1 to
c75dc57
Compare
guy-har
added
the
include-changelog
There was a problem hiding this comment.
There is no clear description what this is meant to do, neither in this PR or in the linked issue #8520
Please provide some documentation what this change is and why we want to make this change
|
@nadavsteindler the information is in the duplicate issue, I'll add it to this issue as well |
No as long as one of the issues has the details- thanks |
pkg/api/controller.go
Outdated
| RBAC: &c.Auth.UIConfig.RBAC, | ||
| loginConfig := &apigen.LoginConfig{ | ||
| RBAC: &c.Auth.UIConfig.RBAC, | ||
| // TODO(Guys): should we consider the authentication api configuration as well |
There was a problem hiding this comment.
Open an issue for this TODO?
There was a problem hiding this comment.
Leftovers, sorry, removing
api/swagger.yml
Outdated
| description: | | ||
| Placeholder text to display in the username field of the login form. | ||
| type: string | ||
| password_placeholder: |
There was a problem hiding this comment.
nit: (none-blocker!)
| password_placeholder: | |
| password_placeholder_label: |
There was a problem hiding this comment.
changed to password_ui_placeholder
api/swagger.yml
Outdated
| @@ -923,6 +923,14 @@ components: | |||
| with an external auth service. | |||
| type: string | |||
| enum: [none, simplified, external] | |||
| username_placeholder: | |||
There was a problem hiding this comment.
nit: (none-blocker!)
| username_placeholder: | |
| username_placeholder_label: |
webui/src/pages/auth/login.tsx
Outdated
| const usernamePlaceholder = loginConfig.username_placeholder ? "Username" : "Access Key ID"; | ||
| const passwordPlaceholder = loginConfig.password_placeholder ? "Password" : "Secret Access Key"; |
There was a problem hiding this comment.
embarrassing 😞
Thanks!
guy-har
force-pushed
the
feature/login-placeholders
branch
from
c305eb1 to
375730a
Compare
guy-har
force-pushed
the
feature/login-placeholders
branch
from
375730a to
52c5a61
Compare
No description provided.