Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: explain mounts on quickstart, working locally #8001

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

ozkatz
Copy link
Collaborator

@ozkatz ozkatz commented Jul 19, 2024

Docs: explain how mounts could be used in the context of the quickstart (Alongside lakectl local) as well as on the "Working with lakeFS Data Locally" how-to page.

@ozkatz ozkatz added docs Improvements or additions to documentation minor-change Used for PRs that don't require issue attached product-task labels Jul 19, 2024
@ozkatz ozkatz self-assigned this Jul 19, 2024
Copy link

github-actions bot commented Jul 19, 2024

♻️ PR Preview 6a6ab5d has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@ozkatz ozkatz added the exclude-changelog PR description should not be included in next release changelog label Jul 19, 2024
#### Prerequisites:

- A working lakeFS Server running either [lakeFS Enterprise](../enterprise) or [lakeFS Cloud](../cloud)
- You’ve installed the [`lakectl`](../reference/cli.html) command line utility: this is the official lakeFS command line interface, on top of which lakeFS Mount is built.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is lakectl a requirement?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it sets up ~/.lakectl.yaml properly. While technically you don't really need the binary itself, once you have it set up, you'll be able to use everest as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this to be confusing. Because even if you download lakectl you still don't have ~/.lakectl.yaml file which means you'll get an error when running everest.
Can you be explicit about the need for lakectl.yaml configuration file? it can even be empty one but this is the actual pre-requisite.

docs/howto/local-checkouts.md Outdated Show resolved Hide resolved
Copy link
Contributor

@talSofer talSofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

non of my comments are blocking

docs/quickstart/work-with-data-locally.md Outdated Show resolved Hide resolved
docs/quickstart/work-with-data-locally.md Outdated Show resolved Hide resolved
docs/quickstart/work-with-data-locally.md Outdated Show resolved Hide resolved
docs/quickstart/work-with-data-locally.md Outdated Show resolved Hide resolved
docs/quickstart/work-with-data-locally.md Outdated Show resolved Hide resolved
The _local_ command of lakeFS' CLI _lakectl_ enables working with lakeFS data locally.
It allows cloning lakeFS data into a directory on any machine, syncing local directories with remote lakeFS locations,
The _local_ command of lakeFS' CLI _lakectl_ enables working with lakeFS data locally by copying the data onto the host machine.
It allows syncing local directories with remote lakeFS locations,
and to [seamlessly integrate lakeFS with Git](#example-using-lakectl-local-in-tandem-with-git).

Here are the available _lakectl local_ commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking but consider adding a section that explains when to use each of the methods.

- You’ve installed the [`lakectl`](../reference/cli.html) command line utility: this is the official lakeFS command line interface, on top of which lakeFS Mount is built.
- lakectl is configured properly to access your lakeFS server as detailed in the configuration instructions

### Mounting a lakeFS reference as a local directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good to mention that lakeFS Mount has a Git integration

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do! probably in a separate PR

@ozkatz ozkatz requested review from Isan-Rivkin and talSofer July 22, 2024 18:48
Copy link
Contributor

@talSofer talSofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 non-blocking comment: the lakectl pre-requisite

@ozkatz ozkatz merged commit 04287d1 into master Jul 23, 2024
36 checks passed
@ozkatz ozkatz deleted the docs/explain-mounts branch July 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached product-task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants