Fix export test esti job #7635
Merged
Fix export test esti job #7635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
area/system-tests
E2E Test Results - DynamoDB Local - Local Block Adapter |
N-o-Z
force-pushed
the
fix/enable-rclone-test
branch
3 times, most recently
from
de1ce22 to
d770136
Compare
N-o-Z
force-pushed
the
fix/enable-rclone-test
branch
from
d770136 to
2e15b4c
Compare
guy-har
approved these changes
Apr 9, 2024
Comment on lines
-37
to
-39
| depends_on: | ||
| - "lakefs" | ||
| - "postgres" |
There was a problem hiding this comment.
Not blocking on this, sharing my thoughts though:
This solves the problem, and because we run it in later steps it works to overcome the dependencies, but we regarding the docker-compose file it's wrong to remove these dependencies.
Did we try using project names?
There was a problem hiding this comment.
I understand the concern, however:
- I feel like we should not invest more time on this since this provides a good enough solution
- Lets address this when this actually becomes painful
Comment on lines
+6
to
+16
| run_cmd_and_validate() { | ||
| echo $1 | ||
| echo "Running: $2" | ||
| newVariable=$(eval $2) | ||
| if [[ $? != "0" ]] | ||
| then | ||
| echo "FAILED!" && exit 1 | ||
| fi | ||
| echo "Output:" | ||
| echo $newVariable | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7628
The main issue was the dependencies in the container configuration that resulted in another lakeFS instance being brought up and which caused some weird collision.
In addition, added prints and status code checks