Skip to content

Commit

Permalink
removing sys dependency for now
Browse files Browse the repository at this point in the history
  • Loading branch information
@soumith
soumith committed Mar 9, 2016
1 parent f7ff82d commit c6554c0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions rocks/torch-scm-1.rockspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ description = {
dependencies = {
"lua >= 5.1",
"paths >= 1.0",
"cwrap >= 1.0",
"sys >= 1.0"
"cwrap >= 1.0"
}

build = {
Expand Down

3 comments on commit c6554c0

@hughperkins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting. I was just about to ask why we install sys after installing torch, in distro/install.sh :-) Do you mind if I ask:

  • why was sys a dependency before?
  • why can we remove it now?
  • implications of removing it?

(Since I'm using torhc as of ~17th Februrary, and it still has a sys dependency)

@fmassa
Copy link
Contributor

@fmassa fmassa commented on c6554c0 Sep 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hughperkins I think this has to do with some deadlock that what happening in some systems. I this this is related to torch/image#157

@hughperkins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that explains removing it. as far as why it was there, just this moment found that the old Tester.lua uses it :-)

tester_sys

Please sign in to comment.