Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rand v0.9 & getrandom v0.3 #11

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Bluefinger
Copy link
Contributor

Pretty straightforward PR, since rand and getrandom have new major versions, this crate should be updated to support them. I've gone and renamed various methods away from their deprecated versions to their new recommended ones (which will be compatible with Rust 2024 edition, given the gen keyword is now reserved going forward).

I also made some changes here and there to silence clippy warnings, but everything should pass the tests and compile just fine. This will necessitate publishing a new major version for fastbloom after this PR is merged.

@Bluefinger
Copy link
Contributor Author

So, nightly removed -Zprofile and with it, the code coverage setup for this repo is broken. It's a bit of a regression on the compiler's part since it seems a lot of things are not quite there yet in terms of stabilisation, and trying to enable it requires doing digging around on how to actually do it that is a bit beyond the scope of this PR and also my expertise.

I've tried to at least make things still testable and keep coverage on what is supported, reverting to compiling/testing on stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant