-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to merge patch #345
base: master
Are you sure you want to change the base?
Conversation
b57fd8c
to
3d720e2
Compare
Add fallback to merge patch if strategic merge patch is unavailable, as is the case for the custom objects API.
3d720e2
to
043429a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 26.91% 26.91% -0.01%
==========================================
Files 799 799
Lines 98316 98332 +16
==========================================
Hits 26463 26463
- Misses 71853 71869 +16 ☔ View full report in Codecov by Sentry. |
I will get to the tests when I can. |
@tomplus I started writing tests, but I noticed that the unit tests for the CustomObjects API are only stubs. There are e2e tests, but there are no e2e tests for CustomObjects (excluding the DynamicClient). Would you like these e2e tests to be added (which would include creating a CRD, creating a custom object of the CRD's type, and then patching the new custom object)? |
Absolutely, it'd be fantastic to have such tests. |
5098e73
to
d886878
Compare
Add fallback to merge patch if strategic merge patch is unavailable, as is the case for the custom objects API.