feat: rMPP support #58
Open
+37
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eeems
reviewed
May 1, 2025
Eeems
reviewed
May 2, 2025
Eeems
reviewed
May 2, 2025
Eeems
requested changes
May 2, 2025
docs/recipe-format.md
Outdated
| @@ -230,6 +232,8 @@ Should match the upstream name as closely as possible. | |||
| The `build()` function runs in the context of a Docker container with the chosen `image`. | |||
| This function has access to all the metadata variables declared above, plus the `$arch` variable which contains the name of the architecture the recipe is currently being built for. | |||
| The working directory is `$srcdir`, which is populated with all the sources declared in `sources`. | |||
| Do note that if you are going to build aarch64 binaries, you must switch to suitable environment variables by sourcing `/opt/x-tools/switch-aarch64.sh`. | |||
There was a problem hiding this comment.
Suggested change
| Do note that if you are going to build aarch64 binaries, you must switch to suitable environment variables by sourcing `/opt/x-tools/switch-aarch64.sh`. | |
| If you are going to build aarch64 binaries, you must switch to suitable environment variables by sourcing `/opt/x-tools/switch-aarch64.sh`. |
I'm wondering if we go back to just automatically running this switch script now that we have it. How long does it take to run?
There was a problem hiding this comment.
0s because it's just setting envvars and nothing more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.