-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test cases showing and dismissing of toasts #280
Add integration test cases showing and dismissing of toasts #280
Conversation
Hey @SDaniV! The integration test cases are failing, are you still working on this issue? |
Hey @tjtanjin! Unfortunately, I didn't manage to understand the reason for the failure the day when I raised the PR. I will try to get it working today and let you know about the result. |
This reverts commit 62a27d3.
Hey again! You can actually run the test locally with Hint: |
Thanks for the hint @tjtanjin! I couldn't reproduce it locally at the beginning because I was running the tests with the UI turned on. Once I switched to running in headless mode, I got the same errors as on the CI. The problem was related to the formatting changes I made. |
Since |
@tjtanjin Thank you for sharing the details 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for taking the time!
Description
Add integration test cases showing and dismissing of toasts
Closes #110
What change does this PR introduce?
Please select the relevant option(s).
What is the proposed approach?
First commit introduces changes that cover toast message in the integrated tests.
Second commit updates formatting in App.tsx file.
Note: if the formatting is unwanted or not well-structured, I can revert that commit.
Checklist: