-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix publish workflow #37
Conversation
📝 WalkthroughWalkthroughThe pull request introduces minor modifications to GitHub Actions workflow configurations for publishing and testing. The changes primarily involve consolidating Poetry installation in the publish workflow and renaming a job in the test workflow from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/publish.yml (2)
22-24
: Consider using the recommended Poetry installation method.While the current approach works, consider using Poetry's recommended installation method for better reliability and security. Also, it's advisable to pin the Poetry version to ensure reproducible builds.
Apply this diff to implement the recommended approach:
run: | - pip install poetry + curl -sSL https://install.python-poetry.org | python3 - --version 1.7.1 poetry installThis change:
- Uses the official installer script
- Pins Poetry to a specific version
- Follows the recommended installation method from Poetry's documentation
Line range hint
1-24
: Consider adding explicit permissions to the workflow.For better security, it's recommended to explicitly define the minimum required permissions for the workflow.
Add these permissions after the
on
section:on: push: tags: - "v*" +permissions: + contents: read + id-token: write # Required for PyPI trusted publishing jobs:This follows the principle of least privilege and prepares for PyPI's trusted publishing feature.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/publish.yml
(1 hunks).github/workflows/test.yml
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/test.yml
Summary by CodeRabbit
tests
totest