3.1.20 is broken (#16)

tiran · Aug 30, 2022 · 12f70e0 · 12f70e0
1 parent aaf2da5
commit 12f70e0
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 20 deletions.
diff --git a/.github/workflows/emsdk.yml b/.github/workflows/emsdk.yml
@@ -20,9 +20,10 @@ jobs:
       fail-fast: false
       matrix:
         emsdk_version:
-          # latest == 3.1.18 passes all tests
-          # - "3.1.18"
-          - latest
+          # 3.1.19 passes all tests
+          - "3.1.19"
+          # latest == 3.1.20 is broken
+          #- latest
           # tot is tip-of-tree
           - tot-upstream
         python_version:
@@ -49,9 +50,13 @@ jobs:
         with:
           python_version: "${{ matrix.python_version }}"
           cache_suffix: "emsdk${{ matrix.emsdk_version }}"
-      - uses: mymindstorm/setup-emsdk@v11
+      - name: "Install EMSDK ${{ matrix.emsdk_version }}"
+        uses: mymindstorm/setup-emsdk@v11
         with:
           version: ${{ matrix.emsdk_version }}
+      - name: Print emcc version
+        shell: bash
+        run: emcc -v
       - name: "Build ${{ matrix.python_version }} ${{ matrix.flavor }}"
         uses: ./.github/actions/build_emscripten
         id: build

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -6,11 +6,11 @@ on:
     inputs:
       python_tag:
         required: true
-        default: "v3.11.0b5"
+        default: "v3.11.0rc2"
         description: "Python release tag"
       emsdk_version:
         required: true
-        default: "3.1.18"
+        default: "3.1.19"
         description: "Emscripten SDK version"
       wasisdk_version:
         required: true

diff --git a/README.md b/README.md
@@ -19,29 +19,29 @@ The `emsdk-tot-upstream` builds are using Emscripte tip-of-tree (nightlies).
 
 ### Emscripten browser target
 
-- `Python-3.11dev-wasm32-emscripten-3.1.18-browser`: Python 3.11 branch, Emscripten SDK 3.1.18
-- `Python-3.11dev-wasm32-emscripten-3.1.18-browser-debug`: Python 3.11 branch,
-  Emscripten SDK 3.1.18, debug build with additional symbols and fewer
+- `Python-3.11dev-wasm32-emscripten-3.1.19-browser`: Python 3.11 branch, Emscripten SDK 3.1.19
+- `Python-3.11dev-wasm32-emscripten-3.1.19-browser-debug`: Python 3.11 branch,
+  Emscripten SDK 3.1.19, debug build with additional symbols and fewer
   optimizations
-- `Python-3.11dev-wasm32-emscripten-3.1.18-browser`: Python main branch (3.12), Emscripten SDK 3.1.18
+- `Python-3.11dev-wasm32-emscripten-3.1.19-browser`: Python main branch (3.12), Emscripten SDK 3.1.19
 
 The files must be served from a web server. You can use the
 `./wasm_webserver.py` script to run a local web server and
 access the browser REPL from http://localhost:8000/python.html
 
 ### Emscripte NodeJS target
 
-- `Python-3.11dev-wasm32-emscripten-3.1.18-node-dl`: WASM dynamic linking, Python
-  3.11 branch, Emscripten SDK 3.1.18
-- `Python-3.11dev-wasm32-emscripten-3.1.18-node-dl-debug`: WASM dynamic linking, Python
-  3.11 branch, Emscripten SDK 3.1.18, debug build with additional debug symbols and fewer
+- `Python-3.11dev-wasm32-emscripten-3.1.19-node-dl`: WASM dynamic linking, Python
+  3.11 branch, Emscripten SDK 3.1.19
+- `Python-3.11dev-wasm32-emscripten-3.1.19-node-dl-debug`: WASM dynamic linking, Python
+  3.11 branch, Emscripten SDK 3.1.19, debug build with additional debug symbols and fewer
   optimizations
-- `Python-3.12dev-wasm32-emscripten-3.1.18-node-dl`: WASM dynamic linking, Python
-  main branch (3.12), Emscripten SDK 3.1.18
-- `Python-3.11dev-wasm32-emscripten-3.1.18-node-pthreads`: WASM pthreads emulation,
-  Python 3.11 branch, Emscripten SDK 3.1.18
-- `Python-3.12dev-wasm32-emscripten-3.1.18-node-pthreads`: WASM pthreads emulation,
-  Python main branch (3.12), Emscripten SDK 3.1.18
+- `Python-3.12dev-wasm32-emscripten-3.1.19-node-dl`: WASM dynamic linking, Python
+  main branch (3.12), Emscripten SDK 3.1.19
+- `Python-3.11dev-wasm32-emscripten-3.1.19-node-pthreads`: WASM pthreads emulation,
+  Python 3.11 branch, Emscripten SDK 3.1.19
+- `Python-3.12dev-wasm32-emscripten-3.1.19-node-pthreads`: WASM pthreads emulation,
+  Python main branch (3.12), Emscripten SDK 3.1.19
 - `Python-3.12dev-wasm64-emscripten-tot-upstream-node`: wasm64-emscripten (MEMORY64),
   Python main branch (3.12), Emscripten SDK tip-of-tree.
 
@@ -77,3 +77,4 @@ Needs a recent version of [wasmtime](https://wasmtime.dev/).
 
 - Emscripten 3.1.14: no main argv with PROXY_TO_PTHREAD [#17338](https://github.com/emscripten-core/emscripten/issues/17338)
 - Emscripten 3.1.16: 64 bit time_t broke utime(), [#17393](https://github.com/emscripten-core/emscripten/issues/17393)
+- Emscripten 3.1.20: argv handling broken [#17720](https://github.com/emscripten-core/emscripten/issues/17720)