feat: add eslint @nx/dependency-checks rule

tinybudgie · Sep 30, 2023 · 52f91f0 · 52f91f0
1 parent 019ee30
commit 52f91f0
Show file tree

Hide file tree

Showing 9 changed files with 58 additions and 21 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -54,6 +54,8 @@ module.exports = [
   ...compat.config({ parser: 'jsonc-eslint-parser' }).map((config) => ({
     ...config,
     files: ['**/*.json'],
-    rules: {},
+    rules: {
+      '@nx/dependency-checks': 'error',
+    },
   })),
 ];
diff --git a/libs/external/health-checks/package.json b/libs/external/health-checks/package.json
@@ -1,4 +1,9 @@
 {
   "name": "@tematools/health-checks",
-  "version": "2.0.0"
+  "version": "2.0.0",
+  "dependencies": {
+    "@golevelup/nestjs-discovery": "4.0.0",
+    "@nestjs/common": "10.2.5",
+    "@nestjs/core": "10.2.5"
+  }
 }
diff --git a/libs/external/health-checks/project.json b/libs/external/health-checks/project.json
@@ -12,8 +12,7 @@
         "outputPath": "dist/libs/external/health-checks",
         "main": "libs/external/health-checks/src/index.ts",
         "tsConfig": "libs/external/health-checks/tsconfig.lib.json",
-        "assets": ["libs/external/health-checks/*.md"],
-        "updateBuildableProjectDepsInPackageJson": true
+        "assets": ["libs/external/health-checks/*.md"]
       }
     },
     "publish": {
@@ -30,7 +29,7 @@
       "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
-        "lintFilePatterns": ["libs/external/health-checks/**/*.ts"]
+        "lintFilePatterns": ["libs/external/health-checks/**/*.ts", "libs/external/health-checks/package.json"]
       }
     },
     "test": {

diff --git a/libs/external/logger/package.json b/libs/external/logger/package.json
@@ -1,4 +1,9 @@
 {
   "name": "@tematools/logger",
-  "version": "0.1.1"
+  "version": "0.1.1",
+  "dependencies": {
+    "chalk": "^4.1.2",
+    "env-var": "^7.4.1",
+    "micromatch": "^4.0.5"
+  }
 }
diff --git a/libs/external/logger/project.json b/libs/external/logger/project.json
@@ -7,17 +7,22 @@
     "build": {
       "clean": true,
       "executor": "@nx/js:tsc",
-      "outputs": ["{options.outputPath}"],
+      "outputs": [
+        "{options.outputPath}"
+      ],
       "options": {
         "outputPath": "dist/libs/external/logger",
         "main": "libs/external/logger/src/index.ts",
         "tsConfig": "libs/external/logger/tsconfig.lib.json",
-        "assets": ["libs/external/logger/*.md"],
-        "updateBuildableProjectDepsInPackageJson": true
+        "assets": [
+          "libs/external/logger/*.md"
+        ]
       }
     },
     "publish": {
-      "dependsOn": ["build"],
+      "dependsOn": [
+        "build"
+      ],
       "command": "node tools/scripts/publish.mjs logger {args.ver} {args.tag}"
     },
     "version": {
@@ -28,14 +33,21 @@
     },
     "lint": {
       "executor": "@nx/linter:eslint",
-      "outputs": ["{options.outputFile}"],
+      "outputs": [
+        "{options.outputFile}"
+      ],
       "options": {
-        "lintFilePatterns": ["libs/external/logger/**/*.ts"]
+        "lintFilePatterns": [
+          "libs/external/logger/**/*.ts",
+          "libs/external/logger/package.json"
+        ]
       }
     },
     "test": {
       "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
+      "outputs": [
+        "{workspaceRoot}/coverage/{projectRoot}"
+      ],
       "options": {
         "jestConfig": "libs/external/logger/jest.config.ts",
         "passWithNoTests": true
@@ -49,4 +61,4 @@
     }
   },
   "tags": []
-}
+}
diff --git a/libs/external/nats/package.json b/libs/external/nats/package.json
@@ -1,4 +1,12 @@
 {
   "name": "@tematools/nats",
-  "version": "1.0.0"
+  "version": "1.0.0",
+  "dependencies": {
+    "@golevelup/nestjs-discovery": "4.0.0",
+    "@nestjs/common": "10.2.5",
+    "@nestjs/core": "10.2.5",
+    "@tematools/health-checks": "^2.0.0",
+    "lodash": "4.17.21",
+    "nats": "^2.16.0"
+  }
 }
diff --git a/libs/external/nats/project.json b/libs/external/nats/project.json
@@ -12,8 +12,7 @@
         "outputPath": "dist/libs/external/nats",
         "main": "libs/external/nats/src/index.ts",
         "tsConfig": "libs/external/nats/tsconfig.lib.json",
-        "assets": ["libs/external/nats/*.md"],
-        "updateBuildableProjectDepsInPackageJson": true
+        "assets": ["libs/external/nats/*.md"]
       }
     },
     "publish": {
@@ -30,7 +29,7 @@
       "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
-        "lintFilePatterns": ["libs/external/nats/**/*.ts"]
+        "lintFilePatterns": ["libs/external/nats/**/*.ts", "libs/external/nats/package.json"]
       }
     },
     "test": {

diff --git a/libs/external/schematics/package.json b/libs/external/schematics/package.json
@@ -3,5 +3,12 @@
   "version": "1.0.1",
   "main": "src/index.js",
   "generators": "./generators.json",
-  "executors": "./executors.json"
+  "executors": "./executors.json",
+  "dependencies": {
+    "@actions/exec": "^1.1.1",
+    "@nx/devkit": "16.8.1",
+    "@nx/js": "16.8.1",
+    "typescript": "^5.1.6",
+    "@nx/linter": "16.8.1"
+  }
 }
diff --git a/libs/external/schematics/project.json b/libs/external/schematics/project.json
@@ -34,8 +34,7 @@
             "glob": "executors.json",
             "output": "."
           }
-        ],
-        "updateBuildableProjectDepsInPackageJson": true
+        ]
       }
     },
     "publish": {
@@ -56,6 +55,7 @@
           "libs/external/schematics/**/*.ts",
           "libs/external/schematics/generators.json",
           "libs/external/schematics/executors.json",
+          "libs/external/schematics/package.json",
           "libs/external/schematics/package.json"
         ]
       }