Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup user handles from Twitter. #87

Merged
merged 2 commits into from
Nov 20, 2022

Conversation

press-rouch
Copy link
Collaborator

Closes #79

We are getting the full metadata and discarding most of it, so we could be doing a lot more with this.

There is a slight inefficiency due to creating new sessions for each of the following, follower, and DM lookups, but I wanted to keep the changes to a minimum for now.

Following and followers tested. DMs not tested as I don't have any.

We are getting the full metadata and discarding most of it, so we could be doing a lot more with this.
Copy link

@JoeTorrey JoeTorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks 🙏

Copy link

@JoeTorrey JoeTorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all the advice and help you guys it’s greatly appreciated

Copy link

@JoeTorrey JoeTorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much and I hope you’re doing well 🙏🤞🏽🙌

@timhutton
Copy link
Owner

image

@timhutton
Copy link
Owner

Works beautifully on my followers, followings and DMs. Nice work @press-rouch

timhutton
timhutton previously approved these changes Nov 20, 2022
Print json parsing of each filename so that we have more context for prompts.
@press-rouch press-rouch dismissed stale reviews from timhutton and JoeTorrey via e6cb01b November 20, 2022 10:42
@timhutton timhutton merged commit cee5e33 into timhutton:main Nov 20, 2022
@timhutton
Copy link
Owner

image

@press-rouch press-rouch deleted the lookup_users branch November 21, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needed: Map missing user_id -> user_handle with remote services
4 participants