fix memory leak in collector #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
|
It actually solves #76, the leak sanitizer will print nothing . But it will still lead to memory leak in tikv status server. I will find the problem 😠 |
|
This is the grafana panel for TiKV. It seems that the memory leak has been successfully resolved by this PR. @crazycs520 |
BusyJay
reviewed
Oct 27, 2021
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
BusyJay
reviewed
Oct 28, 2021
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
BusyJay
approved these changes
Oct 28, 2021
YangKeao
added a commit
that referenced
this pull request
Nov 1, 2021
* fix memory leak in collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use default for collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * allow uninit assumed init Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use vector to initialize array Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
YangKeao
added a commit
that referenced
this pull request
Nov 1, 2021
* fix memory leak in collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use default for collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * allow uninit assumed init Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use vector to initialize array Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
YangKeao
added a commit
that referenced
this pull request
Nov 1, 2021
* fix memory leak in collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use default for collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * allow uninit assumed init Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use vector to initialize array Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
YangKeao
added a commit
that referenced
this pull request
Nov 25, 2021
* fix memory leak in collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use default for collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * allow uninit assumed init Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use vector to initialize array Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
YangKeao
added a commit
to YangKeao/pprof-rs
that referenced
this pull request
Feb 24, 2022
* fix memory leak in collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use default for collector Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * allow uninit assumed init Signed-off-by: YangKeao <yangkeao@chunibyo.icu> * use vector to initialize array Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao yangkeao@chunibyo.icu
I don't know/remember why these
Box:leaks exist in theCollector😢, but they cause the memory leak described in #76 and tikv/tikv#11108 .