-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Accu-Chek meters and pumps using Smart Pix (UPLOAD-685, UPLOAD-872) #1546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While stylistically fairly different than most of the codebase, this seems largely sound. I have a few questions/comments that I'd like to get a bit of feedback on before giving it the thumbs up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post review updates LGTM 👍🏼
The VCLA should be in order, see #1432 (comment). |
efc80e8
to
cd31018
Compare
This PR continues the excellent work done by @mrinnetmaki and @jlaunonen in #1432 to add support for the Roche Accu-Chek Smart Pix device. It handles both meters and the Spirit/Combo pump.
I created a new PR as our CI/CD pipeline will not build binaries for external PRs, and I don't have permission to push to external PRs either.